From nobody Mon Nov 10 17:36:50 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d4xg62y5Kz6H270; Mon, 10 Nov 2025 17:36:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d4xg621v7z4MkW; Mon, 10 Nov 2025 17:36:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762796210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XuNkJCDVa6cpPn8/zKPsPov3FrGVLQmOFTVNm/4lw+c=; b=pYcV5edd45EsNbFuim8Qn0h1d+K2Pdr7dAyD8uLAKucM3eNyvHcDFnYCDdlxW0/XsQwdrm mQI4xxNmV6XwxlSVQpzvOtwcn1iXO3EOX7iqHo2N0/VQwtZ/jaK2ewh9VJAUTeocd6nL8Q uUAfPJaWweNcBYdVpuOYjv27+AMACFHS7vQ06ddaqWgNmLiX31PloOd4V9Q9BtZ+5ZdUBi DGykvGXCJO4Y/SqzLO2YAtvXiSiMqQOXojEH7a09wimMbQ8TsR0xjOqmJH0WuaIkDsChPk nWtoDYZrfOR6AY/i4uZ3kT6TVr2R8HwH8+1AyE2q1RIrfbJwDKrFEXqZxDUukA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762796210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XuNkJCDVa6cpPn8/zKPsPov3FrGVLQmOFTVNm/4lw+c=; b=rLxf2dXflTK9xrGxv3qH/18e9P8U7s/eregwqpceR1gLXATjpkeZYRbeGh69xpNQ/qA2/e 21751Omq7EEAsfQKk5I9ZMDPK6Kl7/lDN8ev8UEKBaPmzkiMFFPZ4t14j/klMV3RTmxY5O xHu8uMgAZbZCLF4yDXh4GXSs3wfObIx46UPmqAF0Ef+8y0Xne6LbGCywCxW4a8hww69dAB zVHvgc89eHwcp+Z5QrW7uiVcMHHhlzVZJSX0qsrfwhbBMY6pbHuk1xdL+byy+mBAqzw613 C/h57qpj9lwo/KywTw3C4gvqCjKRt676fGIFIM/STL4dbMxHaWRaS5GND/rlHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762796210; a=rsa-sha256; cv=none; b=INYBFOiZ67YU0OMrCX/t4CX98zCORgWu161gpd/jd8wviLZ7WgYO6RmsDOakEmVfawwOvG IPx4eOIf5P8eYpOz5crP7lWvwam93SrVlIzkQhLKqRuPRZ90cgwKsqANZoO/4oPuUW23mV vp42shb4zAOsIMKT7yZszgVXOGgz+FPc6t8r68YasT4cP1nIdsIRKkJMAApVBMhStkNqOW hPJKM7MzD7VZmkMBX3P3xOzr99I1LfxmWLPKtvkjUWEKrZdT4qPyKddzcgRIM2pJUu3+R7 pZxXXKrWbkNw1ok6YagPXyVPoNrlDlJGK1JArPoK0zllLOZSG1Ol50Wu7wYG3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d4xg618YpzC0y; Mon, 10 Nov 2025 17:36:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AAHaomP044666; Mon, 10 Nov 2025 17:36:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AAHaoCB044663; Mon, 10 Nov 2025 17:36:50 GMT (envelope-from git) Date: Mon, 10 Nov 2025 17:36:50 GMT Message-Id: <202511101736.5AAHaoCB044663@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gleb Smirnoff Subject: git: a3cd3a4fd68c - stable/15 - netlink: plug lock leak in genl_register_family() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a3cd3a4fd68c8a2ea9264f168441a2ce7d51b4c8 Auto-Submitted: auto-generated The branch stable/15 has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=a3cd3a4fd68c8a2ea9264f168441a2ce7d51b4c8 commit a3cd3a4fd68c8a2ea9264f168441a2ce7d51b4c8 Author: Bruno Silvestre AuthorDate: 2025-11-08 18:02:32 +0000 Commit: Gleb Smirnoff CommitDate: 2025-11-10 17:36:35 +0000 netlink: plug lock leak in genl_register_family() PR: 290893 (cherry picked from commit 335fc09ab8d25c3ced027d46f5a0f4103d5c8bee) --- sys/netlink/netlink_generic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index 00f47e60f013..d20ec4c7545f 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -366,8 +366,10 @@ genl_register_family(const char *family_name, size_t hdrsize, GENL_LOCK(); for (u_int i = 0; i < MAX_FAMILIES; i++) if (families[i].family_name != NULL && - strcmp(families[i].family_name, family_name) == 0) + strcmp(families[i].family_name, family_name) == 0) { + GENL_UNLOCK(); return (0); + } /* Microoptimization: index 0 is reserved for the control family. */ gf = NULL;