From owner-freebsd-arm@FreeBSD.ORG  Sun Dec 22 11:36:41 2013
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 746F2BE5
 for <freebsd-arm@freebsd.org>; Sun, 22 Dec 2013 11:36:41 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 5083F1649
 for <freebsd-arm@freebsd.org>; Sun, 22 Dec 2013 11:36:41 +0000 (UTC)
Received: from bender.Home (97e07ae8.skybroadband.com [151.224.122.232])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id DFD235DFFE;
 Sun, 22 Dec 2013 11:36:39 +0000 (UTC)
Date: Sun, 22 Dec 2013 11:36:33 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Howard Su <howard0su@gmail.com>
Subject: Re: [PATCH] Add stack unwind support for the functions in .ko
Message-ID: <20131222113633.61baf954@bender.Home>
In-Reply-To: <CAAvnz_pE3jO3QutJLYJtm6cfvD=k5nCi5=Q_fWTdmVsj7zfTkw@mail.gmail.com>
References: <CAAvnz_pWZqw-HEB-GTJ_CkErjXrz3v7ozabMXE__vr=SfkBVSg@mail.gmail.com>
 <CAAvnz_p2vw9=HWbGPePKm_yDxM-bM1h6VaQBeJq9sYXPRb2-Lg@mail.gmail.com>
 <20131215173042.0dead636@bender.Home>
 <CAAvnz_qmn+a+-aE4GkYw6TDOPzfST2j5WGvHqKX4WWVsVACSzQ@mail.gmail.com>
 <C6E93F79-BA1C-48E9-8689-775D88462921@bsdimp.com>
 <CAAvnz_r1WsxC0Q+NOWhSs0Wp_Vs9mjpusZVrixsW1v+fwiXDpA@mail.gmail.com>
 <20131222104721.22b1bd45@bender.Home>
 <CAAvnz_pE3jO3QutJLYJtm6cfvD=k5nCi5=Q_fWTdmVsj7zfTkw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: freebsd-arm <freebsd-arm@freebsd.org>
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Dec 2013 11:36:41 -0000

On Sun, 22 Dec 2013 19:22:39 +0800
Howard Su <howard0su@gmail.com> wrote:

> On Sunday, December 22, 2013, Andrew Turner wrote:
> 
> > On Sun, 22 Dec 2013 17:50:31 +0800
> > Howard Su <howard0su@gmail.com <javascript:;>> wrote:
> >
> > > here is the new version which address the print registers out
> > > problem.
> >
> > There are a number of style bugs in this patch: make sure you limit
> > lines to 80 characters; indentation should use tabs, followed by 4
> > spaces if you need to split a long line; braces should be at the
> > end of a line when used with an if, for or while statement.
> >
> Sure. I will fix style(9) issues.
> 
> >
> > You've added the A0 register. I don't see where it is defined by
> > ARM as a register name or synonym. It is also used to adjust which
> > bit from a bitmask we check. This would mean we read the wrong bit
> > and may get a register that was never updated. Because of this we
> > will never read r0.
> >
> Let me find a better name for this macro. What I want is the macro
> describe the register contains first parameter.

You shouldn't need one, the first parameter is in r0.

Andrew