Date: Wed, 12 Mar 2003 17:56:34 -0600 (CST) From: Mike Silbersack <silby@silby.com> To: David Schultz <das@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h vm_pageout.c Message-ID: <20030312175458.J32334@odysseus.silby.com> In-Reply-To: <200303122313.h2CNDHMU046431@repoman.freebsd.org> References: <200303122313.h2CNDHMU046431@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Have you tested this well? I ask only because the last time I played around with the swap killing code, I noticed that it was very fragile. More specifically, the kill signal isn't actually read and the kill performed until the process is swapped in and ran. Hence, with a lot of processes, that could take longer than expected. If you have time, you might consider looking around to see if the kill can be made more immediate. Mike "Silby" Silbersack On Wed, 12 Mar 2003, David Schultz wrote: > das 2003/03/12 15:13:16 PST > > FreeBSD src repository > > Modified files: > sys/vm vm_map.c vm_map.h vm_pageout.c > Log: > - When the VM daemon is out of swap space and looking for a > process to kill, don't block on a map lock while holding the > process lock. Instead, skip processes whose map locks are held > and find something else to kill. > - Add vm_map_trylock_read() to support the above. > > Reviewed by: alc, mike (mentor) > > Revision Changes Path > 1.287 +13 -2 src/sys/vm/vm_map.c > 1.97 +3 -0 src/sys/vm/vm_map.h > 1.227 +7 -2 src/sys/vm/vm_pageout.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030312175458.J32334>