From owner-svn-src-user@FreeBSD.ORG Wed Nov 12 21:59:46 2008 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9EBC91065670; Wed, 12 Nov 2008 21:59:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 782C78FC17; Wed, 12 Nov 2008 21:59:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTP id 0C45E46B03; Wed, 12 Nov 2008 16:59:46 -0500 (EST) Date: Wed, 12 Nov 2008 21:59:45 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Kip Macy In-Reply-To: <200811120732.mAC7W7Sr023153@svn.freebsd.org> Message-ID: References: <200811120732.mAC7W7Sr023153@svn.freebsd.org> User-Agent: Alpine 1.10 (BSF 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r184864 - user/kmacy/HEAD_fast_multi_xmit/sys/netinet X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2008 21:59:46 -0000 On Wed, 12 Nov 2008, Kip Macy wrote: > - if (tp->t_maxopd <= mss) > - return (inp); > - tcp_output_send(tp); > + > + if ((tp->t_flags & TF_RECURSE) == 0) { > + tp->t_flags |= TF_RECURSE; > + tcp_output_send(tp); > + tp->t_flags &= ~TF_RECURSE; > + } Perhaps TF_DONTRECURSE? I find the current polarity slightly confusing. Robert N M Watson Computer Laboratory University of Cambridge > + > return (inp); > } > > > Modified: user/kmacy/HEAD_fast_multi_xmit/sys/netinet/tcp_var.h > ============================================================================== > --- user/kmacy/HEAD_fast_multi_xmit/sys/netinet/tcp_var.h Wed Nov 12 07:16:23 2008 (r184863) > +++ user/kmacy/HEAD_fast_multi_xmit/sys/netinet/tcp_var.h Wed Nov 12 07:32:07 2008 (r184864) > @@ -127,7 +127,8 @@ struct tcpcb { > #define TF_ECN_PERMIT 0x4000000 /* connection ECN-ready */ > #define TF_ECN_SND_CWR 0x8000000 /* ECN CWR in queue */ > #define TF_ECN_SND_ECE 0x10000000 /* ECN ECE in queue */ > - > +#define TF_RECURSE 0x20000000 /* potentially recursing in tcp_output */ > + > tcp_seq snd_una; /* send unacknowledged */ > tcp_seq snd_max; /* highest sequence number sent; > * used to recognize retransmits >