From owner-freebsd-net@FreeBSD.ORG  Thu Jan 29 16:00:08 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 33491917
 for <freebsd-net@freebsd.org>; Thu, 29 Jan 2015 16:00:08 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 147E4E8C
 for <freebsd-net@freebsd.org>; Thu, 29 Jan 2015 16:00:08 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t0TG07jp084754
 for <freebsd-net@freebsd.org>; Thu, 29 Jan 2015 16:00:07 GMT
 (envelope-from mat@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t0TG07Dc084753;
 Thu, 29 Jan 2015 16:00:07 GMT (envelope-from mat)
Date: Thu, 29 Jan 2015 16:00:07 +0000
To: freebsd-net@freebsd.org
From: "gnn (George Neville-Neil)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Requested Changes To] D1697: sfxge: Expect required
 init_state on data path and in periodic calls
Message-ID: <ef05ae99b55caabba504d4938f15ad9f@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1697: sfxge: Expect required init_state on data path and in
 periodic calls
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-ntcdhjyai3rycg66oc5g>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-hutuusvlrz6sglistgnd-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-hutuusvlrz6sglistgnd-req@FreeBSD.org>
Thread-Index: MTVmZWRhZmFiZTk2YzBiOTY0NjE3OTVjNDBkIFTKWQc=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers>,
 <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jan 2015 16:00:08 -0000

gnn requested changes to this revision.
gnn added a comment.
This revision now requires changes to proceed.

__predict_false rarely, if ever, does the right thing.  Have you run any benchmarks to show that this improves performance?

REVISION DETAIL
  https://reviews.freebsd.org/D1697

To: arybchik, gnn
Cc: freebsd-net