From owner-svn-ports-all@FreeBSD.ORG Thu Apr 4 09:24:54 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 4447242D for ; Thu, 4 Apr 2013 09:24:54 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-la0-x22a.google.com (mail-la0-x22a.google.com [IPv6:2a00:1450:4010:c03::22a]) by mx1.freebsd.org (Postfix) with ESMTP id BD14B120 for ; Thu, 4 Apr 2013 09:24:53 +0000 (UTC) Received: by mail-la0-f42.google.com with SMTP id fe20so2299076lab.15 for ; Thu, 04 Apr 2013 02:24:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=nrlX1w+bHrWa1epiNv4x1thm/wZUnS4fEUPbpGE0G5Q=; b=dFymECHS9ftJaG8ZhiRBxk0fH2KDt5mpQqRmUgoonNvW841fTQkeEINZ0TjbPz+nEn z6kw5OqB0/2j7DaS2ky3iyJotzGwXMiKatLaJ9IoHZVhOoHNBHi9pWXf5v1humsLQV/X 0DlQMk8Vr7C9A+5U037VORnBAFR7mwWp65u3rmOiueKk28sZiM7/lVMa0o9zJzRD8q8s 8QdHRrfOXTxZOdMCtl7W4JTBPjHngV/d5SLgM68QFSTwXte+uY1tXoWtoijbSPQlYYg4 r85xpjtYh2FsFU3d0+IzSWvLvWXLJbu8VJhVOSdwp0xQTMuPRKqbJIymdqPTMoi2rglf mqzQ== X-Received: by 10.112.88.10 with SMTP id bc10mr2894891lbb.70.1365067492616; Thu, 04 Apr 2013 02:24:52 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.83.104 with HTTP; Thu, 4 Apr 2013 02:24:32 -0700 (PDT) In-Reply-To: References: <201303251359.r2PDxIXf035701@svn.freebsd.org> <20130328025321.GC72629@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Thu, 4 Apr 2013 17:24:32 +0800 X-Google-Sender-Auth: paFV01QnwliglOads-OBV18Pl1E Message-ID: Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict To: Eitan Adler X-Gm-Message-State: ALoCoQm/bgS6f31jl/cY4oNSOTxZxxNQSzSB+tagLmFefictHVQ5N5+sZHwL8/vuDGHx5JvTsYjv Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, Max Brazhnikov , Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2013 09:24:54 -0000 I think these options can be used globally and also per port. These options are just on by default via bsd.options.mk. Users should be able to turn them off through options dialog while building/installing specific port. I think it has higher possibility that one user wants to install documentation/examples of *some ports but not all ports*. As a result, we should keep those options. At least we shall not always hide them. If maintainers think these options are annoying, they could put them to the end of OPTIONS_DEFINE. On Thu, Mar 28, 2013 at 10:57 AM, Eitan Adler wrote: > On 27 March 2013 22:53, Alexey Dokuchaev wrote: > > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote: > >> New Revision: 315222 > >> URL: http://svnweb.freebsd.org/changeset/ports/315222 > >> > >> - Remove OPTIONS_DEFINE, if it contains only global options > > > > Can you elaborate on this one? Given that there is no clear policy, > > personally I've been always including OPTIONS_DEFINE, even if just for, > say, > > DOCS. > > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set > globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can > reduce user annoyance if the dialog box is not shown for such options. > > > > -- > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams >