From owner-cvs-src@FreeBSD.ORG  Tue Oct 12 22:24:27 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DA15916A4CE; Tue, 12 Oct 2004 22:24:27 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BF5D243D48; Tue, 12 Oct 2004 22:24:27 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id B02FD5C963; Tue, 12 Oct 2004 15:24:27 -0700 (PDT)
Date: Tue, 12 Oct 2004 15:24:27 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Don Lewis <truckman@FreeBSD.org>
Message-ID: <20041012222427.GU38364@elvis.mu.org>
References: <200410122217.i9CMGuoY073261@gw.catspoiler.org>
	<200410122220.i9CMKk5D073276@gw.catspoiler.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200410122220.i9CMKk5D073276@gw.catspoiler.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: jhb@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Oct 2004 22:24:28 -0000

* Don Lewis <truckman@FreeBSD.org> [041012 15:21] wrote:
> On 12 Oct, Don Lewis wrote:
> > On 12 Oct, Alfred Perlstein wrote:
> >> I like this, my only concern is that there may be places that
> >> call this with locks held but with the kernel/user buffer wired
> >> so that it can't fault.
> >> 
> >> Are you sure this isn't the case?  (specifically for some sysctls)
> > 
> > There are a number of sysctl handlers where I added code to wire the
> > buffer so that there was no danger of sleeping while a mutex is held.
> > Allocating a kernel buffer and doing an extra copy would be ugly.
> 
> Oh, nevermind.  The sysctl handlers use copyout(), not uiomove().  Doing
> Adding WITNESS_WARN() to uiomove() is probably a good thing.

Oy. :)  Ok.

-- 
- Alfred Perlstein