From owner-cvs-src@FreeBSD.ORG Wed Mar 9 05:39:57 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 3621016A4CE; Wed, 9 Mar 2005 05:39:57 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.3/8.13.1) with ESMTP id j295dueh037614; Wed, 9 Mar 2005 00:39:56 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.3/8.13.1/Submit) id j295dtg2037613; Wed, 9 Mar 2005 00:39:55 -0500 (EST) (envelope-from green) Date: Wed, 9 Mar 2005 00:39:55 -0500 From: Brian Fundakowski Feldman To: Maxim Sobolev Message-ID: <20050309053955.GB993@green.homeunix.org> References: <200503070726.j277Qhp5059059@repoman.freebsd.org> <20050308012939.GP11079@elvis.mu.org> <422DCF52.6080109@portaone.com> <20050308210414.GU11079@elvis.mu.org> <20050308232209.GX11079@elvis.mu.org> <422E3EC1.4050402@portaone.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <422E3EC1.4050402@portaone.com> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: Alfred Perlstein cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2005 05:39:57 -0000 On Wed, Mar 09, 2005 at 02:09:37AM +0200, Maxim Sobolev wrote: > Looks fine, though it's hard for me to comment about adding yet another > flag that not present in standards. However, in my pretty > unauthoritative opinion, since Linux has it, while many people and ISVs > out there use it as a sort of reference when developing free software, > it will probably make sense to support it as well, especially > considering that it's pretty easy to do. > > In any case, since it's definitelty an API/ABI change (programs that use > MSG_NOSIGNAL won't compile on older systems, while binary programs that > use it may not work correctly on older systems) it also warrants > __FreeBSD_version bump and proper documentation in the Porter's > Handbook. Also the ABI argument probably puts MFC out of question. > > Thanks! Do you need to bump it when #ifdef can already serve that purpose? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\