Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Jul 2012 14:32:06 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Alexander Motin <mav@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r238943 - head/sys/dev/acpica
Message-ID:  <5017C236.6090507@FreeBSD.org>
In-Reply-To: <201207311058.q6VAwp18019777@svn.freebsd.org>
References:  <201207311058.q6VAwp18019777@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
on 31/07/2012 13:58 Alexander Motin said the following:
> To help with diagnostics, add C-state type into dev.cpu.X.cx_supported

I think that this really should have been a separate commit.

Besides it is a POLA violation for those who may parse output of this sysctl for
whatever reason.
Additionally, it would seem to be better to have sub-tree per state per CPU
where all the important/interesting characteristics of the state are exposed.
So this part of this commit seems like a half-measure.

This all has been recently discussed on acpi@ :-)

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5017C236.6090507>