From owner-freebsd-stable@FreeBSD.ORG Fri Apr 28 05:21:13 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24FA616A400; Fri, 28 Apr 2006 05:21:13 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB79D43D46; Fri, 28 Apr 2006 05:21:07 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k3S5L6EI005634; Thu, 27 Apr 2006 23:21:06 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4451A645.6050807@samsco.org> Date: Thu, 27 Apr 2006 23:21:09 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Eugene M. Kim" References: <44518421.60408@nttmcl.com> <20060428032115.GP728@funkthat.com> <4451A140.7090100@nttmcl.com> In-Reply-To: <4451A140.7090100@nttmcl.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: scottl@freebsd.org, John-Mark Gurney , freebsd-stable@freebsd.org Subject: Re: link_elf: symbol cam_simq_alloc undefined X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2006 05:21:13 -0000 Hi, I broke the amr_cam interface several months ago when I locked the driver. I've been neglecting it ever since due to lack of time, and due to the amr_cam interface not being terribly useful. If you do in fact have a use for it, let me know and I'll add it to my TODO list. Scott Eugene M. Kim wrote: > Thanks, that fixed it! : ) > > scottl: Could you commit (and MFC) the fix? It's as simple as adding a > MODULE_DEPEND line: > > MODULE_DEPEND(amr, cam, 1, 1, 1); > > after the DRIVER_MODULE line in src/sys/dev/amr/amr_pci.c > > I'm not sure about amr_linux though; it seems that there's no CAM > reference in amr_linux.c, but that amr_linux is just a compatibility > layer on top of amr. In that light, perhaps: > > MODULE_DEPEND(amr_linux, amr, 1, 1, 1); > > is in order. Also, the existing MODULE_DEPEND line probably should be > changed to: > > MODULE_DEPEND(amr_linux, linux, 1, 1, 1); > > Cheers, > Eugene > > John-Mark Gurney wrote: > >>Eugene M. Kim wrote this message on Thu, Apr 27, 2006 at 19:55 -0700: >> >>>I'm trying to upgrade from 5-stable to 6-stable; after rebooting to the >>>new kernel, the amr(4) module (amr.ko) refuses to load with this message: >>> >>> link_elf: symbol cam_simq_alloc undefined >>> >>>However, a quick nm(1) on /boot/kernel/cam.ko does show: >>> >>> ... >>> 0000f0ac T cam_sim_set_path >>> 0000efc4 T cam_simq_alloc >>> 0000efd4 T cam_simq_free >>> ... >>> >>>and cam.ko is already loaded before amr.ko. >>> >>>What am I missing here? *scratches head 'o 'a* >> >>amr is missing a: >>MODULE_DEPEND(amr, cam, 1, 1, 1); >> >>which means the module doesn't get cam's symbols... might as well add >>that line to amr_linux.c next to MODULE_DEPEND already there... >> > >