From owner-svn-ports-all@freebsd.org Sat Mar 2 19:00:12 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A11951509F2F for ; Sat, 2 Mar 2019 19:00:12 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46C7C75BBB for ; Sat, 2 Mar 2019 19:00:12 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 01AC22DBDA for ; Sat, 2 Mar 2019 19:00:12 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f41.google.com with SMTP id b20so1033246edw.11 for ; Sat, 02 Mar 2019 11:00:11 -0800 (PST) X-Gm-Message-State: APjAAAX9aQjmYJjZ8hQUPWMcsEwinlg7amXr1AAZqZGDmRCQISRh49wR wndbOcAmiaoU9XYeUOU6H/fw0Xav4Uf5JEDVBm+a3w== X-Google-Smtp-Source: APXvYqwvQrT/Tkee0269R2FseCE4zfMnBoarJQuccIPYyhIOgPa5PaCAAkpUKKlyxrHfAhCA2u8XVO1g8YuKzF7/zD4= X-Received: by 2002:a05:6402:12d2:: with SMTP id k18mr8957386edx.58.1551553210823; Sat, 02 Mar 2019 11:00:10 -0800 (PST) MIME-Version: 1.0 References: <201903021804.x22I4KBT029443@repo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Sun, 3 Mar 2019 02:59:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r494447 - in head/textproc/rubygem-nokogiri: . files To: Matthias Fechner Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 46C7C75BBB X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Mar 2019 19:00:12 -0000 On Sun, Mar 3, 2019 at 2:24 AM Matthias Fechner wrote: > Am 02.03.2019 um 19:04 schrieb Sunpoet Po-Chuan Hsieh: > > -RUN_DEPENDS=3D rubygem-pkg-config>=3D1.1.7:devel/rubygem-pkg-config \ > > - rubygem-mini_portile2>=3D2.4.0:devel/rubygem-mini_portile= 2 > > +RUN_DEPENDS=3D rubygem-pkg-config>=3D1.1.7:devel/rubygem-pkg-config > > please see here: > > https://rubygems.org/gems/nokogiri > > regarding this page it is required. > Please read ext/nokogiri/extconf.rb or check ports tree history. As I mentioned in the commit log, we do not need mini_portile/mini_portile2= . It is used to download and build the libraries (libxml2, libxslt, zlib) which is already handled by our ports framework very well. Furthermore, it is not needed when using system libraries (CONFIGURE_ARGS=3D--use-system-libraries) [1][2]. Reference: [1] https://github.com/sparklemotion/nokogiri/blob/v1.10.1/ext/nokogiri/extconf= .rb#L447-L471 [2] https://nokogiri.org/tutorials/installing_nokogiri.html#install-with-system= -libraries Regards, sunpoet > Gru=C3=9F > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > >