From owner-cvs-all Mon Sep 9 13:30: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1647837B400; Mon, 9 Sep 2002 13:29:57 -0700 (PDT) Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7656E43E3B; Mon, 9 Sep 2002 13:29:56 -0700 (PDT) (envelope-from bmah@employees.org) Received: from bmah.dyndns.org ([12.233.149.189]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020909202955.GDCL14182.rwcrmhc52.attbi.com@bmah.dyndns.org>; Mon, 9 Sep 2002 20:29:55 +0000 Received: from intruder.bmah.org (localhost [IPv6:::1]) by bmah.dyndns.org (8.12.6/8.12.6) with ESMTP id g89KTtsU045361; Mon, 9 Sep 2002 13:29:55 -0700 (PDT) (envelope-from bmah@intruder.bmah.org) Received: (from bmah@localhost) by intruder.bmah.org (8.12.6/8.12.6/Submit) id g89KTtoM045360; Mon, 9 Sep 2002 13:29:55 -0700 (PDT) Message-Id: <200209092029.g89KTtoM045360@intruder.bmah.org> X-Mailer: exmh version 2.5+ 20020729 with nmh-1.0.4 To: John Baldwin Cc: "Bruce A. Mah" , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c In-Reply-To: References: Comments: In-reply-to John Baldwin message dated "Mon, 09 Sep 2002 16:16:23 -0400." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.ORG X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_499224134P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Mon, 09 Sep 2002 13:29:55 -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --==_Exmh_499224134P Content-Type: text/plain; charset=us-ascii If memory serves me right, John Baldwin wrote: > On 09-Sep-2002 Bruce A. Mah wrote: > > bmah 2002/09/09 12:44:17 PDT > > > > Modified files: > > usr.sbin/pkg_install/add main.c > > Log: > > Make pkg_install go to the right place for 4.6-RELEASE and 4.6.2-RELEASE > > packages. > > > > Pointed out by: obrien > > Reviewed by: jhb > > Actually, my bad, I think the upper limit for 4.6.2 should likely be 460099, > not 460100. Other than that, thanks! Urk. I just looked over the commit logs for param.h, and you're right, we should have used 460099 there. This would only cause a problem if someone had a pkg_add binary from a recent 4-STABLE or 4.6-STABLE (i.e. after this commit) but they were running it on an old 4-STABLE machine that had a __FreeBSD_version of 460100. Also, 460100 was only in use for 10 hours (plus 40 minutes, and 17 seconds). I guess I ought to go fix this up though, what do you think? For all you young (and not-so-young) src/ committers out there, this is an classic example of why insta-MFCs are bad (or at least risky). Had I waited a day (or even an hour) before doing my MFCs, I would have been able to read jhb's follow-up mail and actually MFC the right code. Bruce. --==_Exmh_499224134P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) Comment: Exmh version 2.5+ 20020506 iD8DBQE9fQTD2MoxcVugUsMRApPMAKDN5qMiWZv/CECm+UWhn3XOtIkhuwCgoZ3J ZPEgX785xaVOG5rXFoGqLNk= =Wamj -----END PGP SIGNATURE----- --==_Exmh_499224134P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message