From owner-freebsd-current@FreeBSD.ORG Thu Dec 21 16:39:19 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0FD0316A403 for ; Thu, 21 Dec 2006 16:39:19 +0000 (UTC) (envelope-from cokane@mail.cokane.org) Received: from ms-smtp-02.texas.rr.com (ms-smtp-02.texas.rr.com [24.93.47.41]) by mx1.freebsd.org (Postfix) with ESMTP id DABA113C44C for ; Thu, 21 Dec 2006 16:39:18 +0000 (UTC) (envelope-from cokane@mail.cokane.org) Received: from ramen.cokane.org (rrcs-24-153-184-158.sw.biz.rr.com [24.153.184.158]) by ms-smtp-02.texas.rr.com (8.13.6/8.13.6) with SMTP id kBLFx5iF024042 for ; Thu, 21 Dec 2006 09:59:06 -0600 (CST) Received: (qmail 28865 invoked by uid 1001); 21 Dec 2006 15:59:15 -0000 Date: Thu, 21 Dec 2006 15:59:15 +0000 From: Coleman Kane To: Yar Tikhiy Message-ID: <20061221155915.GA28845@ramen.coleyandcheryl> References: <20061218153906.GA6910@ramen.coleyandcheryl> <20061221044859.GB63112@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061221044859.GB63112@comp.chem.msu.su> User-Agent: Mutt/1.4.1i X-Virus-Scanned: Symantec AntiVirus Scan Engine X-Mailman-Approved-At: Sat, 23 Dec 2006 12:26:54 +0000 Cc: freebsd-current@freebsd.org, Coleman Kane Subject: Re: UFS_GJOURNAL and ufs.ko X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2006 16:39:19 -0000 I seem to remember that not working properly for me in this case... but I'll give it another try and let you know. On Thu, Dec 21, 2006 at 07:48:59AM +0300, Yar Tikhiy wrote, and it was proclaimed: > On Mon, Dec 18, 2006 at 03:39:06PM +0000, Coleman Kane wrote: > > Hello, > > > > I have noticed (since adding UFS journal support) that the > > UFS_GJOURNAL option hasn't been added to the ufs.ko kernel > > module. I've been using this (out of an effort to test as > > much as possible as KLDs) and every time I upgrade my kernel > > I must manually add -DUFS_GJOURNAL to the CFLAGS line in > > its Makefile. > > > > Is there any specific reason why this can't be committed? > > So far, my experience with GJOURNAL has been great testing > > it both with journal+fs on the same device as well as on > > two seperate devices. > > > > It looks like an oversight to me, but I don't want to jump > > the gun on it if there is some reasonable argument to keep > > it out "by default". > > If I understand you right, you run a custom kernel w/o UFS and load > the latter as a module, don't you? If so, just add "options > UFS_GJOURNAL" to your kernel config file, and the module should > pick up the setting from the kernel build directory then, granted > you build modules with the kernel, not with the world. > > IMHO CFLAGS should go away from ufs.ko's Makefile because the module > should get SOFTUPDATES and UFS_DIRHASH from the kernel configuration, > too. > > -- > Yar