From owner-svn-src-all@FreeBSD.ORG Tue Jan 25 19:35:07 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6324F106566C; Tue, 25 Jan 2011 19:35:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id E74C28FC08; Tue, 25 Jan 2011 19:35:06 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id EA7E241C66F; Tue, 25 Jan 2011 20:35:05 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id ajxOLlBwVMzM; Tue, 25 Jan 2011 20:35:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 6D24441C64A; Tue, 25 Jan 2011 20:35:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 7EABB4448F3; Tue, 25 Jan 2011 19:32:55 +0000 (UTC) Date: Tue, 25 Jan 2011 19:32:55 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Alexander Kabaev In-Reply-To: <201101251917.p0PJHoZN047195@svn.freebsd.org> Message-ID: <20110125192715.H3489@maildrop.int.zabbadoz.net> References: <201101251917.p0PJHoZN047195@svn.freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217833 - head/lib/libelf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2011 19:35:07 -0000 On Tue, 25 Jan 2011, Alexander Kabaev wrote: > Author: kan > Date: Tue Jan 25 19:17:50 2011 > New Revision: 217833 > URL: http://svn.freebsd.org/changeset/base/217833 > > Log: > Do not allocate buffer to hold data for zero-sized sections. Thanks. I understand that this will stop all the WITH_CTF barfing:) The error also had the side effect that objects ended up way biggre than they should be; about +50 to +125% depending on what you look at. .. ERROR: ctfmerge: snd_maestro.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor ERROR: ctfmerge: snd_maestro3.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor ERROR: ctfmerge: snd_neomagic.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor ERROR: ctfmerge: snd_sb16.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor ERROR: ctfmerge: snd_sb8.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor ERROR: ctfmerge: snd_sbc.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor ERROR: ctfmerge: snd_solo.ko.debug: Cannot get sect .note.GNU-stack data: Invalid data buffer descriptor .. > Modified: > head/lib/libelf/elf_data.c > > Modified: head/lib/libelf/elf_data.c > ============================================================================== > --- head/lib/libelf/elf_data.c Tue Jan 25 19:05:46 2011 (r217832) > +++ head/lib/libelf/elf_data.c Tue Jan 25 19:17:50 2011 (r217833) > @@ -115,8 +115,10 @@ elf_getdata(Elf_Scn *s, Elf_Data *d) > d->d_type = elftype; > d->d_version = e->e_version; > > - if (sh_type == SHT_NOBITS) > + if (sh_type == SHT_NOBITS || sh_size == 0) { > + STAILQ_INSERT_TAIL(&s->s_data, d, d_next); > return (d); > + } > > if ((d->d_buf = malloc(msz*count)) == NULL) { > (void) _libelf_release_data(d); > -- Bjoern A. Zeeb You have to have visions! Going to jail sucks -- All my daemons like it! http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html