From owner-svn-src-head@freebsd.org Tue Jan 30 04:13:00 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01D88ED5A02; Tue, 30 Jan 2018 04:13:00 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com [IPv6:2a00:1450:400c:c0c::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 661E6799C7; Tue, 30 Jan 2018 04:12:59 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wr0-x236.google.com with SMTP id a1so9570102wri.5; Mon, 29 Jan 2018 20:12:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=oRTtHKYsFezbxf36nWIVdWetR7bkI9ZYUjQIMbsvTVQ=; b=a416ejMbxT+/uI9zidRiVpxzZ2fGc26WyAKn/K9iHr3L/6rE5XOOV62vc+CtG8ivGo JyRqNpc4m+JoL8vZLooVYPvd1cj+6hk6qLVTFJjrxyrHjYvKOVZ2RlaRjeGMjKEr67TV f+gGi/1jFFEYa+W8wv8gCdtDoN3iFQKxo8VryLlSDXXqtug6Z3tOCCMZI7xEa7aHpq/f X5v1zYK0KqY6dHAAKt6UJO8fm5bCXPxWZTtmuqW9tPOdW5x9dsfdCVZyWQZv9vkYdUo7 v5CgZ4DQBHTa7/saVJvMXLgWnsdxPqOOP73STRS5cYHWsblCoWJScW6vh+z679QTP4Cq 1Caw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=oRTtHKYsFezbxf36nWIVdWetR7bkI9ZYUjQIMbsvTVQ=; b=WTtTwlYpfzl3Zr6bggPEZLmjCswabt1maYZhx1kWPUNVeL4RICv56zSYLJ35e2ABsA QBzrrBwP/vXrXBpR7ElnwEaWgr6vbZMG4JAeClQ1LoSuSeOLDEulYJaT3j+Glwhig/lV n+2+sRyu9kFYDbAktTJh3cJZ/pYidw50nn/UfhMVV+zOF94KMFCt3xw+J+ofKAmTpLjn 7JlCT1ISGYXK/QMiF7BMSkJbibahySzsrIjAMg6t3EfYFnEVrJ+mZXKFaj9gcEG45kBw MLUGnHf3IfrUTsrGaIHR425cI9OJ9KHyYMVzKxZKRywatqOeb7i/37d12t/SZ6QGyvmA 6PFA== X-Gm-Message-State: AKwxyte5JvZU5RdQ8KkWA5zQB2PXJtnheH26cv2/XLc4fryGl2+7zOTq n7ckxyZNhsL//wEc8mZWf5plODy9 X-Google-Smtp-Source: AH8x2278OaCS2YVSV/OipaUNTsHoMGwJlacNMKPKqow55vAP7rJgh6dPnIUusfU60MtbGWO36A0uKQ== X-Received: by 10.223.196.78 with SMTP id a14mr4672914wrg.251.1517285578071; Mon, 29 Jan 2018 20:12:58 -0800 (PST) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id m191sm9837330wma.42.2018.01.29.20.12.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2018 20:12:57 -0800 (PST) From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: svn commit: r328511 - head/sys/dev/extres/clk To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801281520.w0SFKjQe067446@repo.freebsd.org> <4499401.WAFztV9qgp@ralph.baldwin.cx> Message-ID: Date: Tue, 30 Jan 2018 05:12:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <4499401.WAFztV9qgp@ralph.baldwin.cx> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 04:13:00 -0000 On 29.01.2018 18:46, John Baldwin wrote: > On Sunday, January 28, 2018 03:20:45 PM Michal Meloun wrote: >> Author: mmel >> Date: Sun Jan 28 15:20:45 2018 >> New Revision: 328511 >> URL: https://svnweb.freebsd.org/changeset/base/328511 >> >> Log: >> diff --git a/sys/dev/extres/clk/clk.c b/sys/dev/extres/clk/clk.c >> index c6a1f466ceb..c3708a0ce27 100644 >> --- a/sys/dev/extres/clk/clk.c >> +++ b/sys/dev/extres/clk/clk.c >> @@ -642,10 +642,11 @@ clknode_adjust_parent(struct clknode *clknode, int idx) >> if (clknode->parent_cnt == 0) >> return; >> if ((idx == CLKNODE_IDX_NONE) || (idx >= clknode->parent_cnt)) >> - panic("Invalid clock parent index\n"); >> + panic("%s: Invalid parent index %d for clock %s", >> + __func__, idx, clknode->name); >> >> if (clknode->parents[idx] == NULL) >> - panic("%s: Attempt to set invalid parent %d for clock %s", >> + panic("%s: Invalid parent index %d for clock %s", >> __func__, idx, clknode->name); >> >> /* Remove me from old children list. */ >> @@ -674,8 +675,8 @@ clknode_init_parent_idx(struct clknode *clknode, int idx) >> if ((idx == CLKNODE_IDX_NONE) || >> (idx >= clknode->parent_cnt) || >> (clknode->parent_names[idx] == NULL)) >> - panic("%s: Invalid clock parent index: %d\n", __func__, idx); >> - >> + panic("%s: Invalid parent index %d for clock %s", >> + __func__, idx, clknode->name); >> clknode->parent_idx = idx; >> } >> >> Modified: >> head/sys/dev/extres/clk/clk.c > Can you revert and recommit this with a proper log message? > Done in  r328586. I'm sorry, 'svn commit --file ../clk.diff' is very close to 'svn commit --file ../clk.log'. Michal