From owner-freebsd-arch@FreeBSD.ORG  Fri Feb  6 01:06:57 2015
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7AE87729;
 Fri,  6 Feb 2015 01:06:57 +0000 (UTC)
Received: from mail-ig0-x22e.google.com (mail-ig0-x22e.google.com
 [IPv6:2607:f8b0:4001:c05::22e])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 416769A0;
 Fri,  6 Feb 2015 01:06:57 +0000 (UTC)
Received: by mail-ig0-f174.google.com with SMTP id b16so3728879igk.1;
 Thu, 05 Feb 2015 17:06:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=EHQOw8PKuiFacPho93HxW8ikWPn3TceUJYBD+92x2a4=;
 b=PEnIHeAhwWqmvDoJIzSNj8/itMJoSSoC2PLQ8be69YL5OOR3LLq1R0AQGwQag+BhhB
 +JQmUUSMVS+CM2fxlb4ijuBed+UAKkyp6dEqAfc7vXwymo8i8JwudYn+oaH03fjya4y1
 MPYohbKSeuFjh6gLLkz1AiYYaF0llvXMUSH+s22vR1T1ye2A940z8tL15R61sCMl1nin
 aUYmDWHC0Pz5KMwJSUYzb4zydmqTppHgfype6Mg/aex8dJlu5h/CTp4ufp/6Q5zHaL/e
 JtbcGcYtQN79gCLtvuzqfyU8LTdJ8Mttpss1fZTtrZcrqQzyVPJExCB4qiqIttBcnYPg
 ghYw==
MIME-Version: 1.0
X-Received: by 10.43.79.129 with SMTP id zq1mr10311920icb.28.1423184815836;
 Thu, 05 Feb 2015 17:06:55 -0800 (PST)
Received: by 10.50.182.233 with HTTP; Thu, 5 Feb 2015 17:06:55 -0800 (PST)
In-Reply-To: <54D40DC4.9070907@freebsd.org>
References: <39C20BA1-E6B1-4DAE-95BB-8011A0A64D54@bsdimp.com>
 <54D40DC4.9070907@freebsd.org>
Date: Thu, 5 Feb 2015 17:06:55 -0800
Message-ID: <CAGHfRMAdOTUQZvU5D_1KYEyZdoaD4RJ2BTTOgUjrm3sK31U0kw@mail.gmail.com>
Subject: Re: Better way to do conditional inclusion in make
From: NGie Cooper <yaneurabeya@gmail.com>
To: Julian Elischer <julian@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "freebsd-arch@freebsd.org" <arch@freebsd.org>
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Feb 2015 01:06:57 -0000

On Thu, Feb 5, 2015 at 4:41 PM, Julian Elischer <julian@freebsd.org> wrote:

...

> how does it cope with the case where a single file is dependent on either of
> two options.
> (we have this in our tree.. not sure if it occurs in the FreeBSD tree.)
> file could occur in both lists or twice in one list..

This is a good, valid point. I think that Warner's proposal will fix
the simple case (using one knob), but not the more complex case.

What concerns me about the short description of the implementation,
(and something that I'm going to add to the phabricator review) is
that this will:

1. Break using FILESGROUPS
2. Requires creating snippets for dealing with magic in bsd.*.mk (I
wouldn't want this magic going into the general purpose snippets
because it would probably break backwards compatibility).

Thanks!