From owner-freebsd-wireless@FreeBSD.ORG  Mon Sep 24 02:56:07 2012
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6DB29106566C;
	Mon, 24 Sep 2012 02:56:07 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 3712C8FC0C;
	Mon, 24 Sep 2012 02:56:06 +0000 (UTC)
Received: by pbbrp8 with SMTP id rp8so2138742pbb.13
	for <multiple recipients>; Sun, 23 Sep 2012 19:56:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=HM3uYKiKtNMrJ4fhtSjFmCRRBgrpV/U3v7tyzZpbR6k=;
	b=OBs5D+MAqWqjhipGkJhp4oYYSmAQfrmMeGPzgJC298amrqqpfiWVFm0I0TAedAATZB
	ISiJJeviguDZoZkqUH7wn5jfugKWrZlW2P+KBZbxBHYrSlskkBNqapAzD8wOg0MEvLFH
	68xT9wEaFBjFNp8iS6ipY3gruDdLs/LQewDf/BLr+lQ5dPjVsclOm3RTJIxvykMFekIB
	oB33RWyQ1JxlQrllqA5tnbPfpYqo77niczkKPi3DuX7PGPuM5qcbwm83MTLIUMNMJ790
	0eCQXvvXBQZjmpn6Pc6mcD+HMyNLLaTQOVYSEFgv6Xaw++ZWzmFCM3JCdD7hZmV/Hy+Q
	j5xA==
MIME-Version: 1.0
Received: by 10.66.78.73 with SMTP id z9mr29469160paw.9.1348455366573; Sun, 23
	Sep 2012 19:56:06 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.68.36.106 with HTTP; Sun, 23 Sep 2012 19:56:06 -0700 (PDT)
In-Reply-To: <CAAUsrB5TG3zY10Eabs0AQ3j+gMMh0+uGvsTVyqNUhxdyfiJtxw@mail.gmail.com>
References: <CAAUsrB4tG=Xy55kF1=oZy-BT+qWAPsjFiQJOrdSWO-AZcPJqAw@mail.gmail.com>
	<CAJ-Vmok=j0gLzWb8rRzi9J_YgLhdZ4xUhbw=hXoSbRfewtYGMw@mail.gmail.com>
	<1772837970.20120923235212@serebryakov.spb.ru>
	<CAJ-Vmom=FrQ61eyE8JRwbPsxqYLZAJq6xK5xbhEAcruc9wrwhg@mail.gmail.com>
	<1316862759.20120924000232@serebryakov.spb.ru>
	<CAAUsrB5TG3zY10Eabs0AQ3j+gMMh0+uGvsTVyqNUhxdyfiJtxw@mail.gmail.com>
Date: Sun, 23 Sep 2012 19:56:06 -0700
X-Google-Sender-Auth: B5LGGv_eti8shA5PWL0XRht9SZw
Message-ID: <CAJ-Vmonrps2A_zk2b5E0paMq7pm5j-=wZq4oBCxbK-bBnvyogg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Berislav Purgar <bpurgar@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Lev Serebryakov <lev@freebsd.org>, freebsd-wireless@freebsd.org
Subject: Re: broken TX in HEAD (AR5212)
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2012 02:56:07 -0000

Hm, ok.

Change this bit in if_ath_tx.c:

-	flags = HAL_TXDESC_CLRDMASK;		/* XXX needed for crypto errs */
+	//flags = HAL_TXDESC_CLRDMASK;		/* XXX needed for crypto errs */
+	flags = 0;

to just

flags = HAL_TXDESC_CLRDMASK;

See if that works.

Hmph. I thought I caught all the filtered frames weirdness. Obviously
I didn't..

Oh for gods sake. I know what I did wrong. Yes, do the above for now.
I totally screwed up; I thought I had set CLRDMASK correctly for
non-aggregate traffic.

Ok, here's what I did wrong - I didn't set the CLRDMASK
unconditionally for non-aggregate traffic. So the non-11n
(non-aggregate path) has it selectively set - but there's no
completion handler which is putting the traffic on the filtered frames
list and setting the CLRDMASK bit again.

So do the above and please, please file a bug with what you've
gathered. I'll add this to the email and I'll fix it in -HEAD.

Thanks for pointing this out!



Adrian