From owner-freebsd-ports@FreeBSD.ORG  Thu Jul 10 11:18:53 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9C7BA37B404; Thu, 10 Jul 2003 11:18:53 -0700 (PDT)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8F83E43F3F; Thu, 10 Jul 2003 11:18:48 -0700 (PDT)
	(envelope-from pfeifer@dbai.tuwien.ac.at)
Received: from [128.131.111.52] (naos [128.131.111.52])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP
	id 5E4E113791; Thu, 10 Jul 2003 20:18:47 +0200 (CEST)
Date: Thu, 10 Jul 2003 20:18:44 +0200 (CEST)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: Michael Haro <mharo@FreeBSD.org>
Message-ID: <Pine.BSF.4.56.0307102016090.19911@naos.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: ports@freebsd.org
Subject: A small portlint update
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jul 2003 18:18:53 -0000

This adds `file` and `strip` to the list of commands whose direct use
portlint warns about.

Michael, is this okay to commit?  (I'm also Cc:ing this to ports@, in
case others want to chime in and voice comments.)

Gerald

Index: src/portlint.pl
===================================================================
RCS file: /sw/FreeBSD/CVSUP/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.35
diff -u -3 -p -r1.35 portlint.pl
--- src/portlint.pl	7 Mar 2003 17:00:43 -0000	1.35
+++ src/portlint.pl	9 Jul 2003 23:01:08 -0000
@@ -779,7 +779,7 @@ sub checkmakefile {
 	my %cmdnames = ();
 	print "OK: checking direct use of command names.\n" if ($verbose);
 	foreach my $i (qw(
-awk basename cat chmod chown cp echo expr false gmake grep gzcat
+awk basename cat chmod chown cp echo expr false file gmake grep gzcat
 ldconfig ln md5 mkdir mv patch rm rmdir sed sh touch tr which xmkmf
 	)) {
 		$cmdnames{$i} = "\$\{\U$i\E\}";
@@ -788,6 +788,7 @@ ldconfig ln md5 mkdir mv patch rm rmdir
 	$cmdnames{'gunzip'} = '${GUNZIP_CMD}';
 	$cmdnames{'gzip'} = '${GZIP_CMD}';
 	$cmdnames{'install'} = '${INSTALL_foobaa}';
+	$cmdnames{'strip'} = '${STRIP_CMD}';
 	#
 	# ignore parameter string to echo command.
 	# note that we leave the command as is, since we need to check the