From owner-cvs-all  Tue Dec 31 13:16:22 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0514D37B406
	for <cvs-all@freebsd.org>; Tue, 31 Dec 2002 13:16:20 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id A37C143ED8
	for <cvs-all@freebsd.org>; Tue, 31 Dec 2002 13:16:18 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 90374 invoked by uid 1000); 31 Dec 2002 21:16:19 -0000
Date: Tue, 31 Dec 2002 13:16:19 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Alan Cox <alc@FreeBSD.org>
Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h
In-Reply-To: <20021231193809.7DD4037B437@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0212311312480.90110-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, 31 Dec 2002, Alan Cox wrote:
>   Modified files:
>     sys/vm               vm_map.c vm_map.h 
>   Log:
>   Implement a variant locking scheme for vm maps: Access to system maps
>   is now synchronized by a mutex, whereas access to user maps is still
>   synchronized by a lockmgr()-based lock.  
>   
>   Revision  Changes    Path
>   1.278     +38 -16    src/sys/vm/vm_map.c
>   1.94      +1 -0      src/sys/vm/vm_map.h
> 
> +		_mtx_lock_flags(&map->system_mtx, 0, file, line);
> +	else {
> +		error = lockmgr(&map->lock, LK_EXCLUSIVE, NULL, curthread);
> +		KASSERT(error == 0, ("%s: failed to get lock", __func__));
> +	}
> [...]  
> -	lockmgr(&map->lock, LK_RELEASE, NULL, curthread);
> +	if (map->system_map)
> +		_mtx_unlock_flags(&map->system_mtx, 0, file, line);
> +	else
> +		lockmgr(&map->lock, LK_RELEASE, NULL, curthread);
>  }
>  
>  void

Please use the non-underscore, exported mtx_* routines.  The macros expand
to the same thing unless you're doing something strange w/ file and line
(but I don't see that in your patch).

-Nate



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message