Date: Fri, 01 Nov 2013 18:25:46 +0400 From: Boris Samorodov <bsam@passap.ru> To: Ryan Steinmetz <zi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332334 - in head/finance: . vanitygen Message-ID: <5273B9EA.7080904@passap.ru> In-Reply-To: <20131101125940.GA8719@exodus.zi0r.com> References: <201311010112.rA11Ch1h047872@svn.freebsd.org> <52738F84.8060906@passap.ru> <20131101125940.GA8719@exodus.zi0r.com>
next in thread | previous in thread | raw e-mail | index | archive | help
01.11.2013 16:59, Ryan Steinmetz пишет:
>
> On (11/01/13 15:24), Boris Samorodov wrote:
>> Hi Ryan, All,
>>
>> 01.11.2013 05:12, Ryan Steinmetz пишет:
>>
>>> Log:
>>> New port: finance/vanitygen:
>>
>> Thank you for working on new ports. It's always good to get a new one.
>> However there are some notes inlined.
>>
>>> +MAINTAINER= ports@FreeBSD.org
>>
>> I'm not sure that a new unmaintained port is welcomed.
>>
>>> +COMMENT= A standalone vanity address generator for bitcoin
>
> My bad on this, although, I had thought that portlint(1) would have caught
> this.
>
>> Articles should not be used at the beginning of a COMMENT.
>>
>>> +LIB_DEPENDS= pcre:${PORTSDIR}/devel/pcre
>>
>> A new LIB_DEPENDS syntax is preferred.
>
> Do you have the announcement? After digging a bit, the only thing I was
> able to find was the commit log.
I'd say that it was discussed to death via wiki, mailing lists (no
link, sorry) and Handbook:
https://wiki.freebsd.org/ports/fix_lib_depends
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html
>>> +NO_STAGE= yes
>>
>> I think that new ports are supposed to support STAGE.
>
> I do not believe that Tinderbox supports STAGE, so I do not have a means
> of testing it at the moment.
There is a very lightweight (only one dependency) ports-mgmt/poudriere.
It's very simple to install, configure and deploy.
--
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5273B9EA.7080904>