From owner-freebsd-fs@FreeBSD.ORG Wed Sep 15 21:30:55 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B5EE1065670; Wed, 15 Sep 2010 21:30:55 +0000 (UTC) (envelope-from prvs=1874f602db=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) by mx1.freebsd.org (Postfix) with ESMTP id 979F98FC0C; Wed, 15 Sep 2010 21:30:54 +0000 (UTC) X-MDAV-Processed: mail1.multiplay.co.uk, Wed, 15 Sep 2010 22:30:49 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Wed, 15 Sep 2010 22:30:49 +0100 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail1.multiplay.co.uk X-Spam-Level: X-Spam-Status: No, score=-5.0 required=6.0 tests=USER_IN_WHITELIST shortcircuit=ham autolearn=disabled version=3.2.5 Received: from r2d2 by mail1.multiplay.co.uk (MDaemon PRO v10.0.4) with ESMTP id md50011250192.msg; Wed, 15 Sep 2010 22:30:49 +0100 X-Authenticated-Sender: Killing@multiplay.co.uk X-MDRemoteIP: 188.220.16.49 X-Return-Path: prvs=1874f602db=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: From: "Steven Hartland" To: "jhell" References: <20100908084855.GF2465@deviant.kiev.zoral.com.ua> <4C874F00.3050605@freebsd.org> <4C8D087B.5040404@freebsd.org> <03537796FAB54E02959E2D64FC83004F@multiplay.co.uk> <4C8D280F.3040803@freebsd.org> <3FBF66BF11AA4CBBA6124CA435A4A31B@multiplay.co.uk> <4C8E4212.30000@freebsd.org> <20100915104635.GA59871@icarus.home.lan> <8E233260F0334BC58B2C07F383939F8E@multiplay.co.uk> <4C9131F6.10807@DataIX.net> Date: Wed, 15 Sep 2010 22:30:33 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Cc: freebsd-fs@freebsd.org, Pawel Jakub Dawidek , Andriy Gapon Subject: Re: zfs very poor performance compared to ufs due to lack of cache? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 21:30:55 -0000 ----- Original Message ----- From: "jhell" jhell@DataIX.net > On 09/15/2010 06:54, Steven Hartland wrote: >> ----- Original Message ----- From: "Jeremy Chadwick" >> >>> Looks like Andriy just committed something to HEAD/CURRENT which might >>> address this: >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/141305 >> >> Already running that as part of the patches unfortunately, it doesn't seem >> to have any effect. >> > > Is it ? vm_page_set_validclean(m, off, bytes); > I recall you saying that you added this from earlier in the thread. > could be wrong though but what Andriy committed was the following. > > or ? vm_page_set_valid(m, off, bytes); Ahh good catch I have: if (error == 0) vm_page_set_validclean(m, off, bytes); and not as mentioned by 141305: if (error == 0) vm_page_set_valid(m, off, bytes); Which should it actaully be? Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.