From owner-freebsd-dtrace@FreeBSD.ORG Fri Dec 13 07:17:08 2013 Return-Path: Delivered-To: dtrace@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4AF80F2; Fri, 13 Dec 2013 07:17:08 +0000 (UTC) Received: from mail-ve0-x22b.google.com (mail-ve0-x22b.google.com [IPv6:2607:f8b0:400c:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E70871AF7; Fri, 13 Dec 2013 07:17:04 +0000 (UTC) Received: by mail-ve0-f171.google.com with SMTP id pa12so1092062veb.2 for ; Thu, 12 Dec 2013 23:17:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=nua/rjkqozyg4nWi+PyKxqeN/E/5pddKnhd+9L9xLsQ=; b=pefpmrUC3AjFppRfMVsR25Xz18YZHKHCrOFLeNU6+zC3eW7RAzTIiUCOiw+0zoIqyx btpUUYO/RgMVBIq0kJ1otBGfEfk6F1WrJm0bKfpYjCoiHfafT8XhcfPN/so06eT5fLuU OMhkCSBE58mizZ88RoK6VtnYzVEA2rJKtDtcFWYt8GdqmLwWqAek87fxUit5vilUko/B MFbhYi/lzzF83kqT79h5appLIlGWUDswF9SLTk4ex69t2TJsJBSiMTeitp9PkIt9pogu 9yqKAzXBrHJ8IYC76DincvFp5jmVy0zATX0Z7o9YmbZr2rygIY/aFIy5AU9H+8gEY1Jx F6zg== MIME-Version: 1.0 X-Received: by 10.52.26.77 with SMTP id j13mr404312vdg.33.1386919024021; Thu, 12 Dec 2013 23:17:04 -0800 (PST) Received: by 10.220.144.199 with HTTP; Thu, 12 Dec 2013 23:17:03 -0800 (PST) Date: Fri, 13 Dec 2013 08:17:03 +0100 Message-ID: Subject: [CFT] Use vmem in dtrace From: Mike Ma To: "dtrace@freebsd.org" , Pedro Giffuni Content-Type: multipart/mixed; boundary=20cf307d045ac265fb04ed653ff1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Dec 2013 07:17:08 -0000 --20cf307d045ac265fb04ed653ff1 Content-Type: text/plain; charset=ISO-8859-1 Hi there, I'm a GSoC student this year, and Pedro guided me to dtrace recently. I'm sending my patch for a vmem task listed in the TODO list (12th item), as there is vmem subsystem in FreeBSD 10/11 available now. Basically, it is to revert changes from this patch http://lists.freebsd.org/pipermail/p4-projects/2008-January/023466.html And the main difference is that vmem_create and vmem_alloc take different number of parameters on FreeBSD. I did run dtrace testsuite on my own machine. And I hope someone here can try my patch. Any comments are appreciated. Thanks. Cheers, Mike -- Cheers, Mike --20cf307d045ac265fb04ed653ff1 Content-Type: text/plain; charset=US-ASCII; name="dtrace_vmem.diff" Content-Disposition: attachment; filename="dtrace_vmem.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hp2p9e040 SW5kZXg6IHN5cy9jZGRsL2NvbnRyaWIvb3BlbnNvbGFyaXMvdXRzL2NvbW1vbi9kdHJhY2UvZHRy YWNlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gc3lzL2NkZGwvY29udHJpYi9vcGVuc29sYXJpcy91dHMvY29t bW9uL2R0cmFjZS9kdHJhY2UuYwkocmV2aXNpb24gMjU3NzQzKQorKysgc3lzL2NkZGwvY29udHJp Yi9vcGVuc29sYXJpcy91dHMvY29tbW9uL2R0cmFjZS9kdHJhY2UuYwkod29ya2luZyBjb3B5KQpA QCAtMjExLDcgKzIxMSw3IEBACiBzdGF0aWMgdm1lbV90CQkqZHRyYWNlX21pbm9yOwkJLyogbWlu b3IgbnVtYmVyIGFyZW5hICovCiAjZWxzZQogc3RhdGljIHRhc2txX3QJCSpkdHJhY2VfdGFza3E7 CQkvKiB0YXNrIHF1ZXVlICovCi1zdGF0aWMgc3RydWN0IHVucmhkcgkqZHRyYWNlX2FyZW5hOwkJ LyogUHJvYmUgSUQgbnVtYmVyLiAgICAgKi8KK3N0YXRpYyB2bWVtX3QJCSpkdHJhY2VfYXJlbmE7 CQkvKiBwcm9iZSBJRCBhcmVuYSAqLwogI2VuZGlmCiBzdGF0aWMgZHRyYWNlX3Byb2JlX3QJKipk dHJhY2VfcHJvYmVzOwkvKiBhcnJheSBvZiBhbGwgcHJvYmVzICovCiBzdGF0aWMgaW50CQlkdHJh Y2VfbnByb2JlczsJCS8qIG51bWJlciBvZiBwcm9iZXMgKi8KQEAgLTc4MjksMTEgKzc4MjksNyBA QAogCQlrbWVtX2ZyZWUocHJvYmUtPmR0cHJfbW9kLCBzdHJsZW4ocHJvYmUtPmR0cHJfbW9kKSAr IDEpOwogCQlrbWVtX2ZyZWUocHJvYmUtPmR0cHJfZnVuYywgc3RybGVuKHByb2JlLT5kdHByX2Z1 bmMpICsgMSk7CiAJCWttZW1fZnJlZShwcm9iZS0+ZHRwcl9uYW1lLCBzdHJsZW4ocHJvYmUtPmR0 cHJfbmFtZSkgKyAxKTsKLSNpZiBkZWZpbmVkKHN1bikKLQkJdm1lbV9mcmVlKGR0cmFjZV9hcmVu YSwgKHZvaWQgKikodWludHB0cl90KShwcm9iZS0+ZHRwcl9pZCksIDEpOwotI2Vsc2UKLQkJZnJl ZV91bnIoZHRyYWNlX2FyZW5hLCBwcm9iZS0+ZHRwcl9pZCk7Ci0jZW5kaWYKKwkJdm1lbV9mcmVl KGR0cmFjZV9hcmVuYSwgKHZtZW1fYWRkcl90KShwcm9iZS0+ZHRwcl9pZCksIDEpOwogCQlrbWVt X2ZyZWUocHJvYmUsIHNpemVvZiAoZHRyYWNlX3Byb2JlX3QpKTsKIAl9CiAKQEAgLTc5NTAsMTEg Kzc5NDYsNyBAQAogCQlrbWVtX2ZyZWUocHJvYmUtPmR0cHJfZnVuYywgc3RybGVuKHByb2JlLT5k dHByX2Z1bmMpICsgMSk7CiAJCWttZW1fZnJlZShwcm9iZS0+ZHRwcl9uYW1lLCBzdHJsZW4ocHJv YmUtPmR0cHJfbmFtZSkgKyAxKTsKIAkJa21lbV9mcmVlKHByb2JlLCBzaXplb2YgKGR0cmFjZV9w cm9iZV90KSk7Ci0jaWYgZGVmaW5lZChzdW4pCi0JCXZtZW1fZnJlZShkdHJhY2VfYXJlbmEsICh2 b2lkICopKCh1aW50cHRyX3QpaSArIDEpLCAxKTsKLSNlbHNlCi0JCWZyZWVfdW5yKGR0cmFjZV9h cmVuYSwgaSArIDEpOwotI2VuZGlmCisJCXZtZW1fZnJlZShkdHJhY2VfYXJlbmEsICh2bWVtX2Fk ZHJfdClpICsgMSwgMSk7CiAJfQogCiAJbXV0ZXhfZXhpdCgmZHRyYWNlX2xvY2spOwpAQCAtNzk5 MCwxMiArNzk4Miw4IEBACiAJCW11dGV4X2VudGVyKCZkdHJhY2VfbG9jayk7CiAJfQogCi0jaWYg ZGVmaW5lZChzdW4pCi0JaWQgPSAoZHRyYWNlX2lkX3QpKHVpbnRwdHJfdCl2bWVtX2FsbG9jKGR0 cmFjZV9hcmVuYSwgMSwKLQkgICAgVk1fQkVTVEZJVCB8IFZNX1NMRUVQKTsKLSNlbHNlCi0JaWQg PSBhbGxvY191bnIoZHRyYWNlX2FyZW5hKTsKLSNlbmRpZgorCWlkID0gKGR0cmFjZV9pZF90KXZt ZW1fYWxsb2MoZHRyYWNlX2FyZW5hLCAxLAorCQkJCQkJCQkgTV9CRVNURklUIHwgTV9XQUlUT0ss IE5VTEwpOwogCXByb2JlID0ga21lbV96YWxsb2Moc2l6ZW9mIChkdHJhY2VfcHJvYmVfdCksIEtN X1NMRUVQKTsKIAogCXByb2JlLT5kdHByX2lkID0gaWQ7CkBAIC0xMDE4NCw3ICsxMDE3Miw4IEBA CiAJYWdnaWQgPSAoZHRyYWNlX2FnZ2lkX3QpKHVpbnRwdHJfdCl2bWVtX2FsbG9jKHN0YXRlLT5k dHNfYWdnaWRfYXJlbmEsIDEsCiAJICAgIFZNX0JFU1RGSVQgfCBWTV9TTEVFUCk7CiAjZWxzZQot CWFnZ2lkID0gYWxsb2NfdW5yKHN0YXRlLT5kdHNfYWdnaWRfYXJlbmEpOworCWFnZ2lkID0gKGR0 cmFjZV9hZ2dpZF90KSh1aW50cHRyX3Qpdm1lbV9hbGxvYyhzdGF0ZS0+ZHRzX2FnZ2lkX2FyZW5h LCAxLAorCQkJCQkJCQkJCQkJICBNX0JFU1RGSVQgfCBNX1dBSVRPSywgTlVMTCk7CiAjZW5kaWYK IAogCWlmIChhZ2dpZCAtIDEgPj0gc3RhdGUtPmR0c19uYWdncmVnYXRpb25zKSB7CkBAIC0xMDIz Nyw3ICsxMDIyNiw3IEBACiAjaWYgZGVmaW5lZChzdW4pCiAJdm1lbV9mcmVlKHN0YXRlLT5kdHNf YWdnaWRfYXJlbmEsICh2b2lkICopKHVpbnRwdHJfdClhZ2dpZCwgMSk7CiAjZWxzZQotCWZyZWVf dW5yKHN0YXRlLT5kdHNfYWdnaWRfYXJlbmEsIGFnZ2lkKTsKKwl2bWVtX2ZyZWUoc3RhdGUtPmR0 c19hZ2dpZF9hcmVuYSwgKHZtZW1fYWRkcl90KWFnZ2lkLCAxKTsKICNlbmRpZgogCiAJQVNTRVJU KHN0YXRlLT5kdHNfYWdncmVnYXRpb25zW2FnZ2lkIC0gMV0gPT0gYWdnKTsKQEAgLTEzMjExLDEw ICsxMzIwMCwxMCBAQAogCXN0YXRlID0ga21lbV96YWxsb2Moc2l6ZW9mKGR0cmFjZV9zdGF0ZV90 KSwgS01fU0xFRVApOwogI2VuZGlmCiAKKyNpZiBkZWZpbmVkKHN1bikKIAlzdGF0ZS0+ZHRzX2Vw aWQgPSBEVFJBQ0VfRVBJRE5PTkUgKyAxOwogCiAJKHZvaWQpIHNucHJpbnRmKGMsIHNpemVvZiAo YyksICJkdHJhY2VfYWdnaWRfJWQiLCBtKTsKLSNpZiBkZWZpbmVkKHN1bikKIAlzdGF0ZS0+ZHRz X2FnZ2lkX2FyZW5hID0gdm1lbV9jcmVhdGUoYywgKHZvaWQgKikxLCBVSU5UMzJfTUFYLCAxLAog CSAgICBOVUxMLCBOVUxMLCBOVUxMLCAwLCBWTV9TTEVFUCB8IFZNQ19JREVOVElGSUVSKTsKIApA QCAtMTMyMjksOSArMTMyMTgsMTAgQEAKIAlpZiAoZGV2cCAhPSBOVUxMKQogCQkqZGV2cCA9IHN0 YXRlLT5kdHNfZGV2OwogI2Vsc2UKLQlzdGF0ZS0+ZHRzX2FnZ2lkX2FyZW5hID0gbmV3X3Vucmhk cigxLCBJTlRfTUFYLCAmZHRyYWNlX3Vucl9tdHgpOworCXN0YXRlLT5kdHNfYWdnaWRfYXJlbmEg PSB2bWVtX2NyZWF0ZShjLCAodm1lbV9hZGRyX3QpMSwgVUlOVDMyX01BWCwgMSwKKwkgICAgMCwg TV9XQUlUT0spOwogCXN0YXRlLT5kdHNfZGV2ID0gZGV2OwotI2VuZGlmCisjZW5kaWYgCiAKIAkv KgogCSAqIFdlIGFsbG9jYXRlIE5DUFUgYnVmZmVycy4gIE9uIHRoZSBvbmUgaGFuZCwgdGhpcyBj YW4gYmUgcXVpdGUKQEAgLTE0MDM2LDExICsxNDAyNiw3IEBACiAJZHRyYWNlX2Zvcm1hdF9kZXN0 cm95KHN0YXRlKTsKIAogCWlmIChzdGF0ZS0+ZHRzX2FnZ2lkX2FyZW5hICE9IE5VTEwpIHsKLSNp ZiBkZWZpbmVkKHN1bikKIAkJdm1lbV9kZXN0cm95KHN0YXRlLT5kdHNfYWdnaWRfYXJlbmEpOwot I2Vsc2UKLQkJZGVsZXRlX3VucmhkcihzdGF0ZS0+ZHRzX2FnZ2lkX2FyZW5hKTsKLSNlbmRpZgog CQlzdGF0ZS0+ZHRzX2FnZ2lkX2FyZW5hID0gTlVMTDsKIAl9CiAjaWYgZGVmaW5lZChzdW4pCkBA IC0xNTM3NSw3ICsxNTM2MSw3IEBACiAjaWYgZGVmaW5lZChzdW4pCiAJCXZtZW1fZnJlZShkdHJh Y2VfYXJlbmEsICh2b2lkICopKHVpbnRwdHJfdClwcm9iZS0+ZHRwcl9pZCwgMSk7CiAjZWxzZQot CQlmcmVlX3VucihkdHJhY2VfYXJlbmEsIHByb2JlLT5kdHByX2lkKTsKKwkJdm1lbV9mcmVlKGR0 cmFjZV9hcmVuYSwgKHZtZW1fYWRkcl90KXByb2JlLT5kdHByX2lkLCAxKTsKICNlbmRpZgogCQlr bWVtX2ZyZWUocHJvYmUsIHNpemVvZiAoZHRyYWNlX3Byb2JlX3QpKTsKIAl9CkluZGV4OiBzeXMv Y2RkbC9jb250cmliL29wZW5zb2xhcmlzL3V0cy9jb21tb24vc3lzL2R0cmFjZV9pbXBsLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gc3lzL2NkZGwvY29udHJpYi9vcGVuc29sYXJpcy91dHMvY29tbW9uL3N5cy9k dHJhY2VfaW1wbC5oCShyZXZpc2lvbiAyNTc3NDMpCisrKyBzeXMvY2RkbC9jb250cmliL29wZW5z b2xhcmlzL3V0cy9jb21tb24vc3lzL2R0cmFjZV9pbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTEx MzksMTEgKzExMzksNyBAQAogCWludCBkdHNfbnNwZWN1bGF0aW9uczsJCQkvKiBudW1iZXIgb2Yg c3BlY3VsYXRpb25zICovCiAJaW50IGR0c19uYWdncmVnYXRpb25zOwkJCS8qIG51bWJlciBvZiBh Z2dyZWdhdGlvbnMgKi8KIAlkdHJhY2VfYWdncmVnYXRpb25fdCAqKmR0c19hZ2dyZWdhdGlvbnM7 IC8qIGFnZ3JlZ2F0aW9uIGFycmF5ICovCi0jaWYgZGVmaW5lZChzdW4pCiAJdm1lbV90ICpkdHNf YWdnaWRfYXJlbmE7CQkvKiBhcmVuYSBmb3IgYWdncmVnYXRpb24gSURzICovCi0jZWxzZQotCXN0 cnVjdCB1bnJoZHIgKmR0c19hZ2dpZF9hcmVuYTsJCS8qIGFyZW5hIGZvciBhZ2dyZWdhdGlvbiBJ RHMgKi8KLSNlbmRpZgogCXVpbnQ2NF90IGR0c19lcnJvcnM7CQkJLyogdG90YWwgbnVtYmVyIG9m IGVycm9ycyAqLwogCXVpbnQzMl90IGR0c19zcGVjdWxhdGlvbnNfYnVzeTsJCS8qIG51bWJlciBv ZiBzcGVjLiBidXN5ICovCiAJdWludDMyX3QgZHRzX3NwZWN1bGF0aW9uc191bmF2YWlsOwkvKiBu dW1iZXIgb2Ygc3BlYyB1bmF2YWlsICovCkluZGV4OiBzeXMvY2RkbC9kZXYvZHRyYWNlL2R0cmFj ZV9sb2FkLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2NkZGwvZGV2L2R0cmFjZS9kdHJhY2VfbG9hZC5j CShyZXZpc2lvbiAyNTc3NDMpCisrKyBzeXMvY2RkbC9kZXYvZHRyYWNlL2R0cmFjZV9sb2FkLmMJ KHdvcmtpbmcgY29weSkKQEAgLTg0LDkgKzg0LDkgQEAKIAltdXRleF9lbnRlcigmY3B1X2xvY2sp OwogCiAJQVNTRVJUKE1VVEVYX0hFTEQoJmNwdV9sb2NrKSk7CisJZHRyYWNlX2FyZW5hID0gdm1l bV9jcmVhdGUoImR0cmFjZSIsICh2bWVtX2FkZHJfdCkxLCAKKwkJCQkJCQkgICBVSU5UMzJfTUFY LCAxLCAwLCBNX1dBSVRPSyB8IE1fQkVTVEZJVCk7CiAKLQlkdHJhY2VfYXJlbmEgPSBuZXdfdW5y aGRyKDEsIElOVF9NQVgsICZkdHJhY2VfdW5yX210eCk7Ci0KIAlkdHJhY2Vfc3RhdGVfY2FjaGUg PSBrbWVtX2NhY2hlX2NyZWF0ZSgiZHRyYWNlX3N0YXRlX2NhY2hlIiwKIAkgICAgc2l6ZW9mIChk dHJhY2VfZHN0YXRlX3BlcmNwdV90KSAqIE5DUFUsIERUUkFDRV9TVEFURV9BTElHTiwKIAkgICAg TlVMTCwgTlVMTCwgTlVMTCwgTlVMTCwgTlVMTCwgMCk7CkluZGV4OiBzeXMvY2RkbC9kZXYvZHRy YWNlL2R0cmFjZV91bmxvYWQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvY2RkbC9kZXYvZHRyYWNlL2R0 cmFjZV91bmxvYWQuYwkocmV2aXNpb24gMjU3NzQzKQorKysgc3lzL2NkZGwvZGV2L2R0cmFjZS9k dHJhY2VfdW5sb2FkLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwNCw3ICsxMDQsNyBAQAogCiAJa21l bV9jYWNoZV9kZXN0cm95KGR0cmFjZV9zdGF0ZV9jYWNoZSk7CiAKLQlkZWxldGVfdW5yaGRyKGR0 cmFjZV9hcmVuYSk7CisJdm1lbV9kZXN0cm95KGR0cmFjZV9hcmVuYSk7CiAKIAlpZiAoZHRyYWNl X3RveHJhbmdlICE9IE5VTEwpIHsKIAkJa21lbV9mcmVlKGR0cmFjZV90b3hyYW5nZSwgMCk7Cg== --20cf307d045ac265fb04ed653ff1--