From owner-freebsd-current@FreeBSD.ORG  Mon Aug 22 18:14:55 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C105816A41F
	for <freebsd-current@freebsd.org>; Mon, 22 Aug 2005 18:14:55 +0000 (GMT)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D55A643D46
	for <freebsd-current@freebsd.org>; Mon, 22 Aug 2005 18:14:54 +0000 (GMT)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: by rproxy.gmail.com with SMTP id i8so994445rne
	for <freebsd-current@freebsd.org>; Mon, 22 Aug 2005 11:14:51 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=biBC61786f2yXcgv/ZI2YzO3GjV/syvGf9dAGAe+35i1VJbim6t9WpiMxthGlHyEdqbVtdn6VwgpFPL1co5VeTJ7ukfy9JDVnVGrLshD+y86XU+r02h3y0AUKPdqCpoalA5CjRl5x0HBP1yWlym1ttsT8KxnA5JYqGn7Ar7+4XA=
Received: by 10.38.97.2 with SMTP id u2mr66813rnb;
	Mon, 22 Aug 2005 11:14:51 -0700 (PDT)
Received: by 10.38.208.5 with HTTP; Mon, 22 Aug 2005 11:14:51 -0700 (PDT)
Message-ID: <bb4a86c705082211144b0e0e0b@mail.gmail.com>
Date: Mon, 22 Aug 2005 11:14:51 -0700
From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
To: Jonatan B <onatan@gmail.com>
In-Reply-To: <430A12AB.3030800@savvis.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <430A12AB.3030800@savvis.net>
X-Mailman-Approved-At: Tue, 23 Aug 2005 11:48:07 +0000
Cc: freebsd-current@freebsd.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>
Subject: Re: [PANIC] 6.0BETA2 in l2ping flood
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Aug 2005 18:14:55 -0000

Jonatan and Pawel,

> +> This is a repeatable panic I get when l2ping flooding my tungsten.
> +> Maksim?
> +>
> +> repeatable panic with bluetooth on SMP
> +>
> +> #> l2ping -fa MyTungsten -s 65531

[...]

> Fixed in HEAD, thanks for the report.

first, let me thank you both for reporting the problem (Jonatan) and
spending time looking into this (Pawel). i was able to reproduce the
problem and have fix that i will commit after brief testing.

the patch Pawel has committed to HEAD indeed fixes the panic (thanks
Pawel!) however it somewhat hides bigger bug in the bluetooth l2cap
code. the panic happens when l2cap connection descriptor is deleted
with the l2cap command(s) pending in the queue. in this case when the
last l2cap command is deleted (due to cleanup) and reference counter
for the l2cap connection goes down to zero the auto disconnect timeout
is incorrectly set.

thanks,
max