From owner-cvs-all Tue Jul 17 10:10:14 2001 Delivered-To: cvs-all@freebsd.org Received: from kalaid.f2f.com.ua (kalaid.f2f.com.ua [62.149.0.33]) by hub.freebsd.org (Postfix) with ESMTP id 04B7537B401; Tue, 17 Jul 2001 10:09:57 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Received: from mail.uic-in.net (root@[212.35.189.4]) by kalaid.f2f.com.ua (8.11.4/8.11.4) with ESMTP id f6HH9jb27733; Tue, 17 Jul 2001 20:09:45 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (das0-l62.uic-in.net [212.35.189.189]) by mail.uic-in.net (8.11.4/8.11.4) with ESMTP id f6HH7o215684; Tue, 17 Jul 2001 20:07:51 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.4/8.11.3) with ESMTP id f6HH7jD59711; Tue, 17 Jul 2001 20:07:45 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3B5470F5.115605E6@FreeBSD.org> Date: Tue, 17 Jul 2001 20:08:05 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.77 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Garance A Drosihn Cc: Bruce Evans , John Baldwin , Dima Dorfman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Garrett Wollman Subject: Re: cvs commit: src/usr.sbin/zic private.h scheck.c zic.c src/us References: Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Garance A Drosihn wrote: > At 5:47 PM +1000 7/17/01, Bruce Evans wrote: > >On Mon, 16 Jul 2001, John Baldwin wrote: > > > It's (realtively) small, so why not move it to contrib/ to make > > > this more obvious? src/gnu is already somewhat off in its own > > > namespace and is already treated as contrib stuff, however, how > > > are committers supposed to know what "magical" parts of > > > src/usr.s?bin/ are actually 3rd party? > > > >By reading the cvs history. > > We want a hard-and-fast rule that people should not casually > change things in /usr/contrib. It's an easy rule to follow. > If we're going to scatter "contrib" stuff all around the CVS > tree, that makes the rule harder to follow. > > If we're not going to move zic into /usr/contrib, then maybe > we could at least add a '/* NOTE */' to the README and the > start of zic.c noting it's "contrib" status. I just looked > at the CVS log for zic.c, for instance, and I must admit that > nothing really jumped out at me saying "DON'T MODIFY THIS!". > > Yes, I see the bit about "merged changes from vendor branch", > but I suspect that would not wave any red flag at me if I > were just looking to modify this source. Why we can't just add src/usr.sbin/zic/FREEBSD-upgrade file, with detailed information about last import into vendor branch, FreeBSD maintainer, author's e-mail and any others related notes. We have similar files for many contributed packages, so why to seek for something new in this case? -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message