From owner-freebsd-python@freebsd.org Mon Sep 4 11:41:17 2017 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A5ADE0234B for ; Mon, 4 Sep 2017 11:41:17 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5779F704BA for ; Mon, 4 Sep 2017 11:41:17 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mailman.ysv.freebsd.org (Postfix) id 56C5CE02348; Mon, 4 Sep 2017 11:41:17 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 541ABE02347 for ; Mon, 4 Sep 2017 11:41:17 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1AE27704B5 for ; Mon, 4 Sep 2017 11:41:17 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-oi0-x234.google.com with SMTP id h70so1917831oic.1 for ; Mon, 04 Sep 2017 04:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=R+ZCSNzuyqoXUFw3kI77RfrWGV+2mcWXkfQiyKZIKWk=; b=1644yF+9qMSVnmH55XHvZJXgFkEkW/WifnnxKGPgMkxyW4I4+hUz6XpDgXSSxB73g8 AugMnRH00Bo5lnb00YmLMwfhy8ofp7JRfe7jc0D+JRgNBGZ5YkgR98LyGdUcg+yeQk0/ 9kkBRSY3g7JWTksFI6xjId2dV/Cerrnzybd+5eVUx+8OZO5nbfRtna+9NctrXOifwIlq deb2kQNtCGGxHgFWNFBS5SY1hi+Fyn93ZVma/gppjqSuy719jNl/dc6NfKjHk82kdyf+ PZbUCy/CCJMoL8LLfeLnyTF38Cq8R2ka4IbAvEnKE4TG62rAJZYiVpg9Rw9s2OqoLyCM +GXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=R+ZCSNzuyqoXUFw3kI77RfrWGV+2mcWXkfQiyKZIKWk=; b=l7CZnosXcgh4vuVgAx0lAORUB3qpSKSorH2VIxOBJuXQqtOLiW9S/JDapSR7rW2nCM yAp2oKobEJYhTH93Fi1DWUVsyYu5qgYZBSYMMaYayLmsmx6W0pQFNI1WyfMrt0ys3a3G C6B1hZlFid6vKW1h+e2jpZkmFjeFg6eWEtjs3qkx6UO5Qa+2kngm9olmZmVE1oFj1+qX jJmOeqx5h921WMBkQG3avicYepj7otAYu37k216V89dCo7DNN2Qe3tQldE5FpSvnS3xK SEhKGLVB4mlkVdxeD/PECZ6N7cI57TPcLfFSYK0pg/0u7evlce5IQqF5BazFPf1NMa3I Z3LA== X-Gm-Message-State: AHPjjUhhnRrnqxG9znYLZNKDHButWxm8XKX/Y9S3qwoLMl+nJ6oxM0tW F0gdl5pAuKGf+6TByIPKGcL6Re5fD1o/ X-Google-Smtp-Source: ADKCNb4M+D4uye/F909wtK7EZUYTaveMl+8IcwDPXpjP0zcf6l6852bd+ph3ftJu9k0rI+cOlyXYSwyyU4lrbTqrTKA= X-Received: by 10.202.104.74 with SMTP id d71mr333178oic.83.1504525276139; Mon, 04 Sep 2017 04:41:16 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.202.252.5 with HTTP; Mon, 4 Sep 2017 04:40:35 -0700 (PDT) In-Reply-To: <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org> References: <201709031028.v83AS09e027702@repo.freebsd.org> <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Mon, 4 Sep 2017 19:40:35 +0800 X-Google-Sender-Auth: FKgg7XGLh19MC0iupY0LGtcHof4 Message-ID: Subject: Re: svn commit: r449195 - head/security/py-cryptography To: Kubilay Kocak Cc: Rene Ladan , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "python@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 11:41:17 -0000 On Mon, Sep 4, 2017 at 11:29 AM, Kubilay Kocak wrote: > On 9/3/17 8:28 PM, Rene Ladan wrote: > > Author: rene > > Date: Sun Sep 3 10:28:00 2017 > > New Revision: 449195 > > URL: https://svnweb.freebsd.org/changeset/ports/449195 > > > > Log: > > security/py-cryptography: remove support for expired Python 3.3 > > > > Modified: > > head/security/py-cryptography/Makefile > > > > Modified: head/security/py-cryptography/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/security/py-cryptography/Makefile Sun Sep 3 10:12:26 2017 > (r449194) > > +++ head/security/py-cryptography/Makefile Sun Sep 3 10:28:00 2017 > (r449195) > > @@ -35,8 +35,6 @@ RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}ipaddr > ess>0:net/p > > > > .if ${PYTHON_REL} < 3300 > > RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34 > > -.elif ${PYTHON_REL} < 3400 > > -RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py3-enum3= 4 > > .endif > > > > post-install: > > > > Hi, > Please revert this change: > > - It is *meant* to include all versions below 3.4, including 2.7 > I also got confused when I see it at the first time. Note the ".elif" which means ${PYTHON_REL} >=3D 3300 and ${PYTHON_REL} < 34= 00. It only includes python 3.3. > - It is not necessary to delete when a python language port version is > removed. The block still semantically and correctly declares the valid > version dependency requirements from the upstream, independently from > what the tree has at any point in time. > In this case, it should be removed. devel/py3-enum34 depends on expired python 3.3 only. > > Also, if you could, please ask/talk to python maintainers and/or python@ > with regard to port deprecation/deletions before committing. It is not > always entirely obvious or explicit what is the correct thing to do is > without fully understanding the versions support and semantics completely= . > I appreciate Ren=C3=A9's help for cleaning up expired ports. IMHO, if we want to extend the support period, it would be better to change EXPIRATION_DATE before its expiration. Regards, sunpoet > _______________________________________________ > freebsd-python@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-python > To unsubscribe, send any mail to "freebsd-python-unsubscribe@freebsd.org"