From owner-freebsd-fs@FreeBSD.ORG  Tue Jul 28 14:38:54 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 530DF1065678
	for <freebsd-fs@freebsd.org>; Tue, 28 Jul 2009 14:38:54 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 2502A8FC13
	for <freebsd-fs@freebsd.org>; Tue, 28 Jul 2009 14:38:54 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id D1D8846B0C;
	Tue, 28 Jul 2009 10:38:53 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id 307268A0A2;
	Tue, 28 Jul 2009 10:38:53 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Rene Ladan <r.c.ladan@gmail.com>
Date: Tue, 28 Jul 2009 10:38:29 -0400
User-Agent: KMail/1.9.7
References: <200907271400.n6RE05Rv056472@freefall.freebsd.org>
	<200907280941.32840.jhb@freebsd.org>
	<e890cae60907280703v3cefb770j325876ab15030bcc@mail.gmail.com>
In-Reply-To: <e890cae60907280703v3cefb770j325876ab15030bcc@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200907281038.30277.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Tue, 28 Jul 2009 10:38:53 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: freebsd-fs@freebsd.org
Subject: Re: kern/136945: [ufs] [lor] filedesc structure/ufs (poll)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2009 14:38:54 -0000

On Tuesday 28 July 2009 10:03:40 am Rene Ladan wrote:
> 2009/7/28 John Baldwin <jhb@freebsd.org>:
> > On Monday 27 July 2009 10:00:05 am Rene Ladan wrote:
> >> The following reply was made to PR kern/136945; it has been noted by=20
GNATS.
> >>
> >> From: Rene Ladan <rene@freebsd.org>
> >> To: John Baldwin <jhb@freebsd.org>
> >> Cc: bug-followup@freebsd.org
> >> Subject: Re: kern/136945: [ufs] [lor] filedesc structure/ufs (poll)
> >> Date: Mon, 27 Jul 2009 15:51:15 +0200
> >>
> >> =A02009/7/27 John Baldwin <jhb@freebsd.org>:
> >> =A0> I would actually expect this to be the correct order for these two
> > locks.=3D
> >> =A0 =3DA0Can
> >> =A0> you capture the output of the 'debug.witness.fullgraph' sysctl to=
 a=20
file?
> >> =A0>
> >> =A0Yes, see attachment. =A0I'm still running the same 8.0-BETA2.
> >
> > Hmm, the attachment was eaten by a grue, can you post the file somewher=
e?
> >
> Yes, see ftp://rene-ladan.nl/pub/freebsd/kern_136945.txt

Ok, it looks like it did encounter a UFS -> filedesc order at some point.  =
Can=20
you patch sys/kern/subr_witness.c to add a section to the order_lists[] arr=
ay=20
after the 'ZFS locking list' and before the spin locks list that looks like=
=20
this:

	{ "filedesc structure", &lock_class_sx },
	{ "ufs", &lock_class_lockmgr},
	{ NULL, NULL },

=2D-=20
John Baldwin