From owner-svn-ports-all@FreeBSD.ORG Fri Nov 1 14:25:53 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B8482A6F; Fri, 1 Nov 2013 14:25:53 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward4h.mail.yandex.net (forward4h.mail.yandex.net [IPv6:2a02:6b8:0:f05::4]) by mx1.freebsd.org (Postfix) with ESMTP id 6A5932092; Fri, 1 Nov 2013 14:25:53 +0000 (UTC) Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144]) by forward4h.mail.yandex.net (Yandex) with ESMTP id 818B31B208C1; Fri, 1 Nov 2013 18:25:48 +0400 (MSK) Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id C9FCA134031E; Fri, 1 Nov 2013 18:25:47 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id yjjP1xvV3R-PkFaY9wA; Fri, 1 Nov 2013 18:25:47 +0400 Message-ID: <5273B9EA.7080904@passap.ru> Date: Fri, 01 Nov 2013 18:25:46 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Ryan Steinmetz Subject: Re: svn commit: r332334 - in head/finance: . vanitygen References: <201311010112.rA11Ch1h047872@svn.freebsd.org> <52738F84.8060906@passap.ru> <20131101125940.GA8719@exodus.zi0r.com> In-Reply-To: <20131101125940.GA8719@exodus.zi0r.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Nov 2013 14:25:53 -0000 01.11.2013 16:59, Ryan Steinmetz пишет: > > On (11/01/13 15:24), Boris Samorodov wrote: >> Hi Ryan, All, >> >> 01.11.2013 05:12, Ryan Steinmetz пишет: >> >>> Log: >>> New port: finance/vanitygen: >> >> Thank you for working on new ports. It's always good to get a new one. >> However there are some notes inlined. >> >>> +MAINTAINER= ports@FreeBSD.org >> >> I'm not sure that a new unmaintained port is welcomed. >> >>> +COMMENT= A standalone vanity address generator for bitcoin > > My bad on this, although, I had thought that portlint(1) would have caught > this. > >> Articles should not be used at the beginning of a COMMENT. >> >>> +LIB_DEPENDS= pcre:${PORTSDIR}/devel/pcre >> >> A new LIB_DEPENDS syntax is preferred. > > Do you have the announcement? After digging a bit, the only thing I was > able to find was the commit log. I'd say that it was discussed to death via wiki, mailing lists (no link, sorry) and Handbook: https://wiki.freebsd.org/ports/fix_lib_depends http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html >>> +NO_STAGE= yes >> >> I think that new ports are supposed to support STAGE. > > I do not believe that Tinderbox supports STAGE, so I do not have a means > of testing it at the moment. There is a very lightweight (only one dependency) ports-mgmt/poudriere. It's very simple to install, configure and deploy. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve