From owner-svn-src-head@freebsd.org Tue Mar 21 00:55:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0F6AD1309D; Tue, 21 Mar 2017 00:55:40 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E6A1109C; Tue, 21 Mar 2017 00:55:40 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x235.google.com with SMTP id p64so124320093qke.1; Mon, 20 Mar 2017 17:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vd5SUBvfmHdDQaNimRfSN6mJb+QC/iBMseehxz+YVsU=; b=fXufamnXYQd2B1Wcug2NDv8v58SDlKOUxT0rSkUdnF13ftidyt1R36lT/oy+asIBRr FvFZW1cm/mqaQNjwnSTCMhv2fr0sf5i/luL7T26J1Td1e2dAfhTEG/WDhKB9EAJaS7FT pkPf+x2CzI8mU4tCdONiNsnz8vl9G35PXxneAvbHqSfhNWyRQ/MKftevABwgOujBGeGw X7cUf7Ru8ASV9XLpX+Eg24xaMSTfP6ZQXR8l5x3ml5zQl1vewAKaFEY1xIN3sbAp5hDR Bw/zu6kt0nSjWSpDV7dHhWCSRJmGHzywYK3xakpG3LkjG+AO5QXarIPEGQ2CrXWZ7Huo v9lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vd5SUBvfmHdDQaNimRfSN6mJb+QC/iBMseehxz+YVsU=; b=jDdR+yZMdk1hFGcPMiXW8m5WpEEFYr/LXeOREaaAltthAuX/WoV45UpHGMEAIojaFj meWGGNH7E3p0/Pu4vQUpKtcTem+pUmbdDj507xGDUYVQYDqVJYlltQCT49KbFacJhbwh MuSm7e9Rg/Z3yyBYNQervR/kUkhL/6O895LbxN0lBnf7c2bm2An1HIBt6mcfmQKKb/5f H12WlJK38RpSfx5iTDjTRBg76SGf4iph46QJfvxv7eZuFajFLlTkfJSMO6Y8t0lg9poA zsVmSr29xdMqgJav1g7fPCluj1X5xG8T5sGJfH+ZaecGBica3g05PSDLqOrnfRjTiXkw sHXw== X-Gm-Message-State: AFeK/H29/wHU8lz9+87ulGx3XX2/SKm5opfpU1o7aK0QxwLTxo4QWkojShdd3Y7NNVA2E8VIANaUJcbfCDu7jw== X-Received: by 10.55.192.145 with SMTP id v17mr30624101qkv.3.1490057739505; Mon, 20 Mar 2017 17:55:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.93.18 with HTTP; Mon, 20 Mar 2017 17:55:39 -0700 (PDT) In-Reply-To: <201703202307.v2KN7Y5n071357@repo.freebsd.org> References: <201703202307.v2KN7Y5n071357@repo.freebsd.org> From: Ngie Cooper Date: Mon, 20 Mar 2017 17:55:39 -0700 Message-ID: Subject: Re: svn commit: r315656 - head/tests/sys/netinet To: Alan Somers Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 00:55:40 -0000 On Mon, Mar 20, 2017 at 4:07 PM, Alan Somers wrote: > Author: asomers > Date: Mon Mar 20 23:07:34 2017 > New Revision: 315656 > URL: https://svnweb.freebsd.org/changeset/base/315656 > > Log: > Fix back-to-back runs of sys/netinet/fibs_test;slaac_on_nondefault_fib6 > > This test was failing if run twice because rtadvd takes too long to die. > The rtadvd process from the first run was still running when the > second run created its interfaces. The solution is to use SIGKILL during > the cleanup instead of SIGTERM so rtadvd will die faster. > > While I'm here, randomize the addresses used for the test, which makes bugs > like this easier to spot, and fix the cleanup order to be the opposite of > the setup order > > PR: 217871 > MFC after: 18 days > X-MFC-With: 315458 > Sponsored by: Spectra Logic Corp Hi Alan, I wonder if another seatbelt needs to be added for this scenario because running a separate copy of rtadvd could adversely affect the running system behavior... Thanks, -Ngie