Date: Mon, 20 Mar 2017 17:55:39 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r315656 - head/tests/sys/netinet Message-ID: <CAGHfRMBo7sbkRiWFu1A2gMNi2z%2BBOStNYHwVTXtos3T6G6MTww@mail.gmail.com> In-Reply-To: <201703202307.v2KN7Y5n071357@repo.freebsd.org> References: <201703202307.v2KN7Y5n071357@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 20, 2017 at 4:07 PM, Alan Somers <asomers@freebsd.org> wrote: > Author: asomers > Date: Mon Mar 20 23:07:34 2017 > New Revision: 315656 > URL: https://svnweb.freebsd.org/changeset/base/315656 > > Log: > Fix back-to-back runs of sys/netinet/fibs_test;slaac_on_nondefault_fib6 > > This test was failing if run twice because rtadvd takes too long to die. > The rtadvd process from the first run was still running when the > second run created its interfaces. The solution is to use SIGKILL during > the cleanup instead of SIGTERM so rtadvd will die faster. > > While I'm here, randomize the addresses used for the test, which makes bugs > like this easier to spot, and fix the cleanup order to be the opposite of > the setup order > > PR: 217871 > MFC after: 18 days > X-MFC-With: 315458 > Sponsored by: Spectra Logic Corp Hi Alan, I wonder if another seatbelt needs to be added for this scenario because running a separate copy of rtadvd could adversely affect the running system behavior... Thanks, -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMBo7sbkRiWFu1A2gMNi2z%2BBOStNYHwVTXtos3T6G6MTww>