From owner-dev-commits-src-main@freebsd.org Wed Dec 30 12:04:56 2020 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 12B6E4C0E8A; Wed, 30 Dec 2020 12:04:56 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5VMq5rMMz3HXR; Wed, 30 Dec 2020 12:04:55 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 0BUC4qmh081947; Wed, 30 Dec 2020 04:04:52 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 0BUC4qX7081946; Wed, 30 Dec 2020 04:04:52 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202012301204.0BUC4qX7081946@gndrsh.dnsmgr.net> Subject: Re: git: 70e64ba44941 - main - release.sh: Update GITROOT URL In-Reply-To: To: Warner Losh Date: Wed, 30 Dec 2020 04:04:52 -0800 (PST) CC: Glen Barber , Kyle Evans , "Rodney W. Grimes" , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4D5VMq5rMMz3HXR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for the main branch of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 12:04:56 -0000 > On Tue, Dec 29, 2020, 7:21 PM Glen Barber wrote: > > > On Tue, Dec 29, 2020 at 06:36:45PM -0600, Kyle Evans wrote: > > > On Tue, Dec 29, 2020, 18:18 Rodney W. Grimes > > > wrote: > > > > > > > > The branch main has been updated by gjb: > > > > > > > > > > URL: > > > > > > https://cgit.FreeBSD.org/src/commit/?id=70e64ba4494190e64ab8faa04d744182d420c275 > > > > > > > > > > commit 70e64ba4494190e64ab8faa04d744182d420c275 > > > > > Author: Glen Barber > > > > > AuthorDate: 2020-12-29 14:34:05 +0000 > > > > > Commit: Glen Barber > > > > > CommitDate: 2020-12-29 14:40:28 +0000 > > > > > > > > > > release.sh: Update GITROOT URL > > > > > > > > > > Hard-code the GITROOT for the ports tree to use cgit-beta > > > > > until the ports repository is converted. > > > > > > > > > > While here, remove $FreeBSD$ RCS IDs. > > > > > > > > So how do I know what version of some file I am looking at > > > > once it has been dis-associated from a git clone? > > > > > > > > Is there some new mechanism that can give me the cadence of > > > > say, /etc/pkg/FreeBSD.conf once its FreBSD ID is riped out? > > > > > > > > Also if $FreeBSD$ needs to be removed, can we please just do > > > > it in one massive tree wide commit rather than have this > > > > random piece wise needless noise in 1000's of commits? > > > > > > > > > > > > I don't see any particularly compelling reason to strip these tags, > > > personally. I stripped them from caroot because we embedded them in > > > generated files and it creates a lot of noise on updatecerts that I do > > not > > > need/want, while providing no value to justify the noise for a purely > > > generated file. > > > > They are not used/updated, so why keep a tag that does not expand to any > > useful information? > > > > Deleting all the $FreeBSD$ in on go is massively unwise (or as the British > might say, "a very brave plan"). It will screw up MFCs on an epic scale for > years for no real benefit to pay for that extra developer time. It itself > can't be MFCd. It's a terrible idea. We should not be deleting them, except > judiciously for things that cannot be MFCd. With the subversion exporter, > they will live on in stable/12. Just exactly how would this screw up MFC's on an epic scale? Your NOT going to merge this massive commit, which as long as you don't touch lines near $FreeBSD$ things should just be fine. Now commiting a change to $FreeBSD$ along with OTHER changes is a sure fire way to cause a MFC conflict, but not anything major that can not be dealt with via conflict resolution. Now what is being just shoved off as nothing is the fact without $FreeBSD$ working the ability to backtrace cadence of a file is going to be a royal pain in the ass, and basically means the project has "lost" versioning of installed product. > Warner -- Rod Grimes rgrimes@freebsd.org