From owner-freebsd-scsi Thu Feb 21 11:14:26 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80]) by hub.freebsd.org (Postfix) with ESMTP id 4CC6D37B400 for ; Thu, 21 Feb 2002 11:14:22 -0800 (PST) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id LAA01758; Thu, 21 Feb 2002 11:12:51 -0800 (PST) Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [162.62.64.10]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id KAA16097; Thu, 21 Feb 2002 10:55:32 -0800 (PST) Received: from btcexc01.btc.adaptec.com (btcexc01 [162.62.147.10]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id MAA15558; Thu, 21 Feb 2002 12:12:48 -0700 (MST) Received: by btcexc01.btc.adaptec.com with Internet Mail Service (5.5.2653.19) id <1TZTVY72>; Thu, 21 Feb 2002 12:12:49 -0700 Message-ID: From: "Long, Scott" To: "'Justin T. Gibbs'" , Hidetoshi Shimokawa Cc: freebsd-scsi@freebsd.org, joerg_wunsch@uriah.heep.sax.de Subject: RE: READ_6 patch (Re: RBC support patch) Date: Thu, 21 Feb 2002 12:12:48 -0700 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Also, after the 6 byte command has failed and been retried successfully as a 10 byte command, should the driver be flagged that all future commands use the 10 byte form? Scott > -----Original Message----- > From: Justin T. Gibbs [mailto:gibbs@scsiguy.com] > Sent: Thursday, February 21, 2002 11:02 AM > To: Hidetoshi Shimokawa > Cc: freebsd-scsi@freebsd.org; joerg_wunsch@uriah.heep.sax.de > Subject: Re: READ_6 patch (Re: RBC support patch) > > > >> This seems right way to go. > > > >How about this? > >Could you review this patch? > > Close. Perform the test inside daerror(). Daerror is > supposed to filter > out any errors specific to the da driver prior to calling the generic > error routine, so this is the place to handle this. You > should also only > need to do the filtering if the ccb has an error flagged in its ccb > header. This should avoid any unecessary work on transactions that > haven't failed. Lastly, you need to actually requeue the transaction > (xpt_action() followed by a release of the device queue if > the transaction > was marked as having frozen the queue). > > Thanks for looking into this! > > -- > Justin > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-scsi" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message