From owner-svn-ports-all@freebsd.org Sat Jan 4 20:00:01 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 796871F3B1D for ; Sat, 4 Jan 2020 20:00:01 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47qt0c2ck1z4Y1R for ; Sat, 4 Jan 2020 19:59:59 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wr1-x442.google.com with SMTP id q10so6499250wrm.11 for ; Sat, 04 Jan 2020 11:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=itYc/6/fRd3hvka8f1T5ii+33KKN3NcDZ3ROhf2CwM0=; b=EKz+ucHPx8rpmeEo9iW/DRv436ICKLJ3MMQth9KWjpHAOx8ZlkE8FAeE7zGquwSb1k OHMk/1MGC44hVsEqOWTGT8RIQsxwGhH7AMuXTUmd1Fh0T+FeM7adODFx5YArA3tsqAAD u9XQKE+zIF+q+EgcJPpJ6UPlUUuv8/V0mw1BagOOYK8EjSroAXgr764Zj64wltLhgYUG FlN5BvKHijgFZOvTT71qlhlngY3E0/si8pZwKWvb9ZBKe6kQezzUqS61NbcmvGVgEOgz sgaMvy9tMPLtic6n1sGcZi+LS4Nnkgd8MSYndINKvgnBqgyf4KSlW8QLTrRngxTQRVr0 VU7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=itYc/6/fRd3hvka8f1T5ii+33KKN3NcDZ3ROhf2CwM0=; b=V4JOCkuL2MewuFKyI58De1+mRopZJzmFqbc5m7p/fhdg0/rlyM2r7deJY+ufM5Gq9V bcnLkRm9wdL0IzeBMpDpRd/8Y0pkzUgpzU+xkdsmgNNZL1QIoayT1AzZkonEtrVAEy/B Wy6OUBPORoerpXmPEiiAW/phJHMfyCRbqeZa/GktfSctoM2d1Ay4uZ33WKGst73RLGz/ rxVGbz9HHtHQlppMcuer2S2dglmij7qpY64UdEEUS2bfJRA0UAr8wsRPgW6XKc3VJhfT KQHhn308cSbHcWni4Cv5OEsCv6qw2AKLn4VVwsGS5SrcbVH/Vw6Kg7XdcokXz4cOU7zJ OxSg== X-Gm-Message-State: APjAAAXqQeELAotjJbcddqrouvQzGW8vPy5JnmHPm0iAKbPpbFSSi0iw 3JoOyICWFL/q9jj53uNB8W2s3OVh7eot/awEqUcHbw== X-Google-Smtp-Source: APXvYqy3g6ySvxz1CuxS3vQFaJQYNQKSdvxgMiRm+IR9h1VjVK6o/3MExtx+4g++vZfnfdeQhoHiGI0tdGV1qLhgp3A= X-Received: by 2002:adf:b193:: with SMTP id q19mr94491144wra.78.1578167997867; Sat, 04 Jan 2020 11:59:57 -0800 (PST) MIME-Version: 1.0 References: <202001030056.0030umrE001847@repo.freebsd.org> <20200103083628.b7b2b46pea33vu5f@atuin.in.mat.cc> <2968169.bT80LyP3VS@beastie.bionicmutton.org> <29C42407-97B1-4DDB-BEC3-DB397ECD85C7@freebsd.org> <6ba53399-84f5-961f-1fa1-1fb53f8f984f@FreeBSD.org> <77DAB365-CC5A-40B3-B1C9-C9562C442833@freebsd.org> In-Reply-To: <77DAB365-CC5A-40B3-B1C9-C9562C442833@freebsd.org> From: Adam Weinberger Date: Sat, 4 Jan 2020 12:59:41 -0700 Message-ID: Subject: Re: svn commit: r521892 - in head/math: . R-cran-alabama To: Devin Teske Cc: Pedro Giffuni , Adriaan de Groot , Mathieu Arnold , ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 47qt0c2ck1z4Y1R X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=EKz+ucHP; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::442 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-2.93 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-ports-all@freebsd.org]; DMARC_NA(0.00)[adamw.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-0.43)[ip: (2.36), ipnet: 2a00:1450::/32(-2.62), asn: 15169(-1.86), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2020 20:00:01 -0000 On Fri, Jan 3, 2020 at 1:02 PM Devin Teske wrote: > > > > On Jan 3, 2020, at 11:17, Pedro Giffuni wrote: > > > On 03/01/2020 13:01, Devin Teske wrote: > > > On Jan 3, 2020, at 06:50, Adriaan de Groot wrote: > > On Friday, 3 January 2020 09:36:28 CET Mathieu Arnold wrote: > > On Fri, Jan 03, 2020 at 12:56:48AM +0000, Devin Teske wrote: > > Author: dteske (src committer) > > As stated by this ^^^^^^^^^^^^^ you are not a ports committer. So you > are required to get approval, and state the approval in your commits, > saying it has been reviewed is not enough. > > Reviewed by: mat, imp (previous revision) > Differential Revision: https://reviews.freebsd.org/D22675 > > Question for mat@, just to be clear: the issue here is (only) that there > should be an extra line in the commit message, > Approved by: mat > or possibly > Approved by: mat (mentor) > as described in the committer's guide [1]. > > The Phab review was approved (accepted), so it's just the documentation o= f > process? > > > [1] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide= / > commit-log-message.html > > The process is broken currently as I=E2=80=99ve been denied a ports commi= t bit and my mentorship is null and void for a ports bit. > > I do not not know how to navigate such a situation. > > In this case, would review be akin to approval and thus, whomsoever revie= wed it that is an active ports committer is therefore the approver? > > > Active committers can commit to other parts of the tree if they get appro= val from other active committers in that branch. It works both ways: src co= mmitters can (exceptionally) do ports or doc commits, and the other way aro= und. However, a phabricator review is not an approval unless it is explicit= . > > Just my $0.02, > > > What explicitly constitutes apprroval then? An accepted phab review, an accepted BZ PR, or any private interaction (email, irc, smoke signals, telepathy) approving the patch. We keep the bar really low intentionally; just get any ports committer to explicitly approve a patch and you can commit it (though the commit message has to state explicitly who approved it). # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org