From owner-freebsd-current@freebsd.org Fri Dec 25 22:25:12 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A2D644CBFA6 for ; Fri, 25 Dec 2020 22:25:12 +0000 (UTC) (envelope-from steffen@sdaoden.eu) Received: from sdaoden.eu (sdaoden.eu [217.144.132.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2hMq5bxwz4Sm9 for ; Fri, 25 Dec 2020 22:25:11 +0000 (UTC) (envelope-from steffen@sdaoden.eu) Received: by sdaoden.eu (Postfix, from userid 1000) id 8964416057; Fri, 25 Dec 2020 23:25:10 +0100 (CET) Date: Fri, 25 Dec 2020 23:25:10 +0100 From: Steffen Nurpmeso To: Warner Losh Cc: FreeBSD Current Subject: Re: src: continued use of Subversion for getting updates Message-ID: <20201225222510.JyYwH%steffen@sdaoden.eu> In-Reply-To: References: <20201223143545.Wf_Ww%steffen@sdaoden.eu> <20201225214041.jVKMU%steffen@sdaoden.eu> Mail-Followup-To: Warner Losh , FreeBSD Current User-Agent: s-nail v14.9.20-84-g7268a84d OpenPGP: id=EE19E1C1F2F7054F8D3954D8308964B51883A0DD; url=https://ftp.sdaoden.eu/steffen.asc; preference=signencrypt BlahBlahBlah: Any stupid boy can crush a beetle. But all the professors in the world can make no bugs. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4D2hMq5bxwz4Sm9 X-Spamd-Bar: - X-Spamd-Result: default: False [-1.81 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[217.144.132.164:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a:c]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[sdaoden.eu]; SPAMHAUS_ZRD(0.00)[217.144.132.164:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.51)[-0.511]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15987, ipnet:217.144.128.0/20, country:DE]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Dec 2020 22:25:12 -0000 Warner Losh wrote in : |> On Fri, Dec 25, 2020 at 2:41 PM Steffen Nurpmeso |> wrote: |>> Ulrich Sp=C3=B6rlein wrote in |>> : |>>|On Wed, 2020-12-23 at 15:35:45 +0100, Steffen Nurpmeso wrote: |>>|>Jeffrey Bouquet wrote in |>>|> : |>>|>|On Wed, 23 Dec 2020 11:13:07 +0100, Johan Hendriks |>> >|>|om> wrote: |>>|>|> On 23/12/2020 09:49, Warner Losh wrote: |>>|>|>> On Wed, Dec 23, 2020, 1:48 AM Graham Perrin < |>> grahamperrin@gmail.com> \ |>>|>|>> wrote: |>>|> ... |>>|>|> First of all a big thank you for all your time and effort you and |>> all |>>|>|> the other people put in this tremendous task. |>>|> |>>|>Yes, it is great to have FreeBSD as a stable git repository now, |>> ... |>>|>I really dislike that vendor imports have been tagged. Because |>>|>there is only one tag namespace you cannot avoid getting all this |>>|>cruft. I mean, it is too late now, but one could have used ... |>>|That's basically what was done? I don't understand what you're saying |>>|here ... |>> |>> Well, cgit-beta did not have had all these tags if i recall |>> correctly, did it? I mean it has been two months or so since |>> i last had it because "git fetch" bailed here due to the errors |>> that i have reported, and fetching more than a gigabyte for |>> brand-new fetches devastates here. |> |> It had them, but not under the refs/head/vendor space but under the |> refs/vendor space. These are not tags but branches. I have nothing against the branches, of course. Only the tags are the problem. |> The multiple gigabyte fetch is because we changed the hashes two or thr= ee |> times in the last few months. Yes i know. No problem (well, for me, of course), i tried it at least once more by the end of November, but the server did not finish my request (the simple "git fetch" in a non-clean repo). |> But i _think_ all the tags below refs/tags/vendor/ like |>> |>> vendor/wpa/2.9 |>> vendor/wpa_supplicant/0.3.8 |>> vendor/wpa_supplicant/0.5.10 |>> vendor/wpa_supplicant/0.5.11 |>> vendor/x86emu/4.6 |>> vendor/xe/1.13 |>> |>> etc. did not exist in cgit-beta? I surely would have said |>> something once comments have been requested, wouldn't i? |> |> They did exist. They were under refs/vendor rather than refs/head/vendor |> though. Under refs/tags/vendor? refs/tags/ is the "special" namespace managed by "git tag", this is different than the rest. |>> The thing is if i do |>> |>> #?0|kent:free-src.git$ git ls-remote|wc -l |>> From https://git.freebsd.org/src.git |>> 6814 |>> |>> This is a tremendous amount of head references that need to be |>> compared. ... |>> there is |>> |>> #?0|kent:free-src.git$ git sr|wc -l |>> 2137 |>> |>> but if i go for "the real" FreeBSD itself it is just |>> |>> #?0|kent:free-src.git$ git sr | grep -v vendor | wc -l |>> 19 |> |You might be happier tracking on github, once we start pushing there as t= he |vendor branches won't be published there. No problem with any number of branches, Warner. Just tags under refs/tags this is above. ... |>> and thus |>> |>> #?0|kent:free-src.git$ git sr | grep vendor | wc -l |>> 2118 |>> |>> Which is a pity since all these references will be checked during |>> "git fetch" unless i am mistaken. |> |Yes. So far it's been doing it quite quickly for me, but I'm decently |connected... Yes, terrible here, shared with many. ... |>>|That's a valid point, we debated whether to keep vendor tags and |>> decided |>>|for now to replicate what we have in SVN. We can still delete all the |>>|vendor tags on the main repo anytime we want ... |>> |>> I personally would track that in the commit message of the import |>> on the vendor branch that anyway exists(!), and then when merging |>> this into the mainline, but not create a real tag in the tag |>> namespace. Also the backups/ and such, because why? |> |We need tags to keep track of what's been done, and to revert and do other |management things with vendor imports. But why? You have the commit on a topic/vendor branch, and you revert nothing but the commit. In fact doing so messes the tag, it has to be retagged when you do re-commit an import proper, which requires a forced push even! Ciao, --steffen | |Der Kragenbaer, The moon bear, |der holt sich munter he cheerfully and one by one |einen nach dem anderen runter wa.ks himself off |(By Robert Gernhardt)