From owner-freebsd-current@freebsd.org Sat Aug 8 08:43:45 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95A8F9B3421 for ; Sat, 8 Aug 2015 08:43:45 +0000 (UTC) (envelope-from julien@jch.io) Received: from mail-qg0-f52.google.com (mail-qg0-f52.google.com [209.85.192.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 550391BE2 for ; Sat, 8 Aug 2015 08:43:45 +0000 (UTC) (envelope-from julien@jch.io) Received: by qgeg42 with SMTP id g42so52871274qge.1 for ; Sat, 08 Aug 2015 01:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version :newsgroups:to:cc:subject:references:in-reply-to:content-type; bh=1xvGIpD6izX+7MmBaFKPB/3o2oDK7MBVS+jAWWLjyYI=; b=bvxOu60i8Yp5ZFxxnF4NBZvcdvuRBDGAHsc2G1ACri+dWwdXJs4WjVr1w1f3slhgDg DetAERzABid+luEGLqNU07g8EEVrLBCuWEBOehNL8qBTAzYFTBogNlAitj+ikkxwsp7M UIeyWEdA9Exy7OyYM6P+eCquwYozwTuyyqVA8shP7ZGZby48jnOHFN0Srwj8iXOsYzXD yO85Jqd2gI8AvN8v/DtdIfgtEPEEf+eYiHALFD2782GeMiqufjKaQA9ol+qovVJPQvn8 295m3SESimQCE/LsNlZFYQa+oWXwJM+W7OMj6FUwh1gD34jLjAbmUG58ss7QdlG9sUXe y8ZA== X-Gm-Message-State: ALoCoQmaK891v999JNIePdfcNo0kLaPM8Yvg6ONgUd/yr+9xDNk6IZXqWDUn8arynSa9yM3x7wjf X-Received: by 10.140.88.163 with SMTP id t32mr21324782qgd.92.1439023418587; Sat, 08 Aug 2015 01:43:38 -0700 (PDT) Received: from res1slal-l1.vcorp.ad.vrsn.com (h87.s239.verisign.com. [216.168.239.87]) by smtp.googlemail.com with ESMTPSA id 7sm6289908qhf.13.2015.08.08.01.43.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Aug 2015 01:43:37 -0700 (PDT) Message-ID: <55C5C12E.9020907@freebsd.org> Date: Sat, 08 Aug 2015 10:43:26 +0200 From: Julien Charbon User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 Newsgroups: gmane.os.freebsd.current To: Mark Johnston , Larry Rosenman CC: freebsd-current@FreeBSD.org Subject: Re: traceroute6: panic: pcb not read locked References: <20150808010324.GA1392@borg.lerctr.org> <20150808032521.GA66493@raichu> <55C59872.8070701@freebsd.org> In-Reply-To: <55C59872.8070701@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ekM0gfGA0ew1hpvSNPlkMSSuTKROIXp4n" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2015 08:43:45 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ekM0gfGA0ew1hpvSNPlkMSSuTKROIXp4n Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 08/08/15 07:49, Julien Charbon wrote: > On 08/08/15 05:25, Mark Johnston wrote: >> On Fri, Aug 07, 2015 at 08:04:01PM -0500, Larry Rosenman wrote: >>> Trying to debug TimeWarner IPV6 to my HE.NET tunnel, and running trac= eroute6,=20 >>> got the following panic: >>> >>> borg.lerctr.org dumped core - see /var/crash/vmcore.0 >>> >>> Fri Aug 7 19:58:40 CDT 2015 >>> >>> FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #32 r286338= : Wed Aug 5 15:57:55 CDT 2015 root@borg.lerctr.org:/usr/obj/usr/src/= sys/VT-LER amd64 >>> >>> panic: Lock tcp not read locked @ /usr/src/sys/netinet/tcp_subr.c:118= 9 >>> >>> GNU gdb 6.1.1 [FreeBSD] >>> Copyright 2004 Free Software Foundation, Inc. >>> GDB is free software, covered by the GNU General Public License, and = you are >>> welcome to change it and/or distribute copies of it under certain con= ditions. >>> Type "show copying" to see the conditions. >>> There is absolutely no warranty for GDB. Type "show warranty" for de= tails. >>> This GDB was configured as "amd64-marcel-freebsd"... >>> >>> Unread portion of the kernel message buffer: >>> panic: Lock tcp not read locked @ /usr/src/sys/netinet/tcp_subr.c:118= 9 >> >> This appears to be fallout from r286227: the tcpinfo lock assertion in= >> tcp_notify() is too strong, since tcp_notify() can still be called fro= m >> c with the tcpinfo write lock held. >=20 > Nice catch, I agree these tcpinfo lock assertion are too strong. I am= > fixing and testing that as in top of tcp_notify() and tcp_drop(), you > also need to update also tcp_close() and tcp_detach(). I pushed a fix in r286443. I am checking if other paths have the same issue of kernel assertions being too strict with INP_INFO read/write lock checks. Thanks for the detailed report and patch proposal. -- Julien --ekM0gfGA0ew1hpvSNPlkMSSuTKROIXp4n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVxcE2AAoJEKVlQ5Je6dhx4ZoH/0Xi2okSW7jiHiqAIbdjJUut 2wV5EzwluwaMLEJMNVM7I52t5GYdCjmIHr4m2OftzQlzEvACseHZWPLV+UmiekAb tFTpgGGp1F1UaQQH3G5eP+YwY/zaSb8lopfDJ/wMhKVUVc//O5vGJdcetGggW88a d0F99cQt+uVh0shqdbPz3PDcJPpjs3vETO5BgtR8ZcNzE9VptnEo3u7C5QFga59M xQaNoVj79UpD1Wl5xOBAgIDVB6M95x/HWsvBf716VzTI+Y7HWafgOOO4KNJo5tCI PqH/qfwyTM+jpRyX6thYUkxJs/Vq1ua4kT8AkXmIwP3j0USz7vduWjMW4LUjZOY= =61YW -----END PGP SIGNATURE----- --ekM0gfGA0ew1hpvSNPlkMSSuTKROIXp4n--