From owner-svn-src-head@FreeBSD.ORG Fri Dec 17 16:21:31 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51ECD106566B; Fri, 17 Dec 2010 16:21:31 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3F9918FC08; Fri, 17 Dec 2010 16:21:31 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oBHGLUJK087314; Fri, 17 Dec 2010 16:21:30 GMT (envelope-from avg@svn.freebsd.org) Received: (from avg@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id oBHGLUxK087309; Fri, 17 Dec 2010 16:21:30 GMT (envelope-from avg@svn.freebsd.org) Message-Id: <201012171621.oBHGLUxK087309@svn.freebsd.org> From: Andriy Gapon Date: Fri, 17 Dec 2010 16:21:30 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r216503 - head/sys/dev/acpica X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 16:21:31 -0000 Author: avg Date: Fri Dec 17 16:21:30 2010 New Revision: 216503 URL: http://svn.freebsd.org/changeset/base/216503 Log: small cleanup of acpi battery status setting and checking This is based on the patch submitted by Yuri Skripachov. Overview of the changes: - clarify double-use of some ACPI_BATT_STAT_* definitions - clean up undefined/extended status bits returned by _BST - warn about charging+discharging bits being set at the same time PR: kern/124744 Submitted by: Yuri Skripachov Tested by: Yuri Skripachov MFC after: 2 weeks Modified: head/sys/dev/acpica/acpi_battery.c head/sys/dev/acpica/acpi_cmbat.c head/sys/dev/acpica/acpi_smbat.c head/sys/dev/acpica/acpiio.h Modified: head/sys/dev/acpica/acpi_battery.c ============================================================================== --- head/sys/dev/acpica/acpi_battery.c Fri Dec 17 15:39:55 2010 (r216502) +++ head/sys/dev/acpica/acpi_battery.c Fri Dec 17 16:21:30 2010 (r216503) @@ -102,8 +102,9 @@ acpi_battery_get_info_expire(void) int acpi_battery_bst_valid(struct acpi_bst *bst) { - return (bst->state < ACPI_BATT_STAT_MAX && bst->cap != ACPI_BATT_UNKNOWN && - bst->volt != ACPI_BATT_UNKNOWN); + + return (bst->state != ACPI_BATT_STAT_NOT_PRESENT && + bst->cap != ACPI_BATT_UNKNOWN && bst->volt != ACPI_BATT_UNKNOWN); } /* Check _BIF results for validity. */ Modified: head/sys/dev/acpica/acpi_cmbat.c ============================================================================== --- head/sys/dev/acpica/acpi_cmbat.c Fri Dec 17 15:39:55 2010 (r216502) +++ head/sys/dev/acpica/acpi_cmbat.c Fri Dec 17 16:21:30 2010 (r216503) @@ -279,6 +279,12 @@ acpi_cmbat_get_bst(void *arg) goto end; acpi_cmbat_info_updated(&sc->bst_lastupdated); + /* Clear out undefined/extended bits that might be set by hardware. */ + sc->bst.state &= ACPI_BATT_STAT_BST_MASK; + if ((sc->bst.state & ACPI_BATT_STAT_INVALID) == ACPI_BATT_STAT_INVALID) + ACPI_VPRINT(dev, acpi_device_get_parent_softc(dev), + "battery reports simultaneous charging and discharging\n"); + /* XXX If all batteries are critical, perhaps we should suspend. */ if (sc->bst.state & ACPI_BATT_STAT_CRITICAL) { if ((sc->flags & ACPI_BATT_STAT_CRITICAL) == 0) { Modified: head/sys/dev/acpica/acpi_smbat.c ============================================================================== --- head/sys/dev/acpica/acpi_smbat.c Fri Dec 17 15:39:55 2010 (r216502) +++ head/sys/dev/acpica/acpi_smbat.c Fri Dec 17 16:21:30 2010 (r216503) @@ -390,6 +390,7 @@ acpi_smbat_get_bst(device_t dev, struct if (val > 0) { sc->bst.rate = val * factor; + sc->bst.state &= ~SMBATT_BS_DISCHARGING; sc->bst.state |= ACPI_BATT_STAT_CHARGING; } else if (val < 0) sc->bst.rate = (-val) * factor; Modified: head/sys/dev/acpica/acpiio.h ============================================================================== --- head/sys/dev/acpica/acpiio.h Fri Dec 17 15:39:55 2010 (r216502) +++ head/sys/dev/acpica/acpiio.h Fri Dec 17 16:21:30 2010 (r216503) @@ -74,11 +74,22 @@ struct acpi_bst { uint32_t volt; /* Present Voltage */ }; +/* + * Note that the following definitions represent status bits for internal + * driver state. The first three of them (charging, discharging and critical) + * conveninetly conform to ACPI specification of status returned by _BST + * method. Other definitions (not present, etc) are synthetic. + * Also note that according to the specification the charging and discharging + * status bits must not be set at the same time. + */ #define ACPI_BATT_STAT_DISCHARG 0x0001 #define ACPI_BATT_STAT_CHARGING 0x0002 #define ACPI_BATT_STAT_CRITICAL 0x0004 -#define ACPI_BATT_STAT_NOT_PRESENT 0x0007 -#define ACPI_BATT_STAT_MAX 0x0007 +#define ACPI_BATT_STAT_INVALID \ + (ACPI_BATT_STAT_DISCHARG | ACPI_BATT_STAT_CHARGING) +#define ACPI_BATT_STAT_BST_MASK \ + (ACPI_BATT_STAT_INVALID | ACPI_BATT_STAT_CRITICAL) +#define ACPI_BATT_STAT_NOT_PRESENT ACPI_BATT_STAT_BST_MASK union acpi_battery_ioctl_arg { int unit; /* Device unit or ACPI_BATTERY_ALL_UNITS. */