From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Oct 14 18:10:47 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 86064136 for ; Tue, 14 Oct 2014 18:10:47 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 528E2F81 for ; Tue, 14 Oct 2014 18:10:47 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s9EIAlEv008363 for ; Tue, 14 Oct 2014 18:10:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194312] games/minecraft-server issues after update to 1.8 Date: Tue, 14 Oct 2014 18:10:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: freebsd@oldach.net X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2014 18:10:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194312 --- Comment #7 from Helge Oldach --- (In reply to John Marino from comment #6) > I don't understand this: >=20 > .for file in ${CONFIG_FILES} > ${TOUCH} ${STAGEDIR}${ETCDIR}/${file}.sample > ${LN} -s ${ETCDIR}/${file} ${STAGEDIR}${DATADIR}/${file} > .endfor >=20 > What is this doing? >=20 > 1) it looks like blank sample files are being created Exactly. For some reasons the maintainer decided to install blank configura= tion files instead of meaningful content with the 1.8 port revision. At least, f= or server.properties it would really be sensible to install some pre-configured content. This was the case for the previous port revision. No idea why it w= as changed. Yes, these blank config files are ugly, however I felt it would be more sensible to make use of existing pkg logic rather than bloating Makefile wi= th in-line scripts. > 2) It looks like the next line was intended to be > ${LN} -s ${ETCDIR}/${file} ${STAGEDIR}${DATADIR}/${file}.sample Definitely not: The location of the configuration files is %%ETCDIR%%, i.e. /usr/local/etc/minecraft-server. In *this* location both the .sample file a= nd the user-modified "real" configuration file are located. However, the minec= raft executable expects its config files in %%DATADIR%%, i.e. /usr/local/share/minecraft-server, which is why symlinks are created there pointing to real file location (without .sample suffix). This is intentiona= l. > and even if it was, that's wrong. @sample keyword would take care of it. No, it doesn't. Tried and tested here (very recent 9-STABLE with pkg 1.3.8). > Can you fix the other issues? All we want is a patch (and not have to > create one ourselves) If I would want to be the port maintainer, I would volunteer. It did not. I= am just a bug reporter. --=20 You are receiving this mail because: You are the assignee for the bug.=