From owner-freebsd-current@FreeBSD.ORG  Tue Mar  9 04:37:20 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 90BF416A4CE; Tue,  9 Mar 2004 04:37:20 -0800 (PST)
Received: from snow.csi.cam.ac.uk (snow.csi.cam.ac.uk [131.111.8.15])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BE50643D39; Tue,  9 Mar 2004 04:37:19 -0800 (PST)
	(envelope-from br260@hermes.cam.ac.uk)
Received: from maroon.csi.cam.ac.uk ([131.111.8.2])
	by snow.csi.cam.ac.uk with esmtp (Exim 4.20)
	id 1B0gU0-0005iZ-Dx; Tue, 09 Mar 2004 12:37:16 +0000
Received: from prayer by maroon.csi.cam.ac.uk with local (Exim 4.24)
	id 1B0gU0-0004ly-9M; Tue, 09 Mar 2004 12:37:16 +0000
From: Bin Ren <br260@cam.ac.uk>
To: freebsd-current@freebsd.org
Date: 09 Mar 2004 12:37:16 +0000
X-Mailer: Prayer v1.0.9
X-Originating-IP: [131.111.242.109]
Mime-Version: 1.0
Content-Type: text/plain; format=flowed; charset=ISO-8859-1
Message-Id: <E1B0gU0-0004ly-9M.--1c41a3d54c4fc50bd9d924e41c4ca767a2f5dfd9@maroon.csi.cam.ac.uk>
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
X-Cam-AntiVirus: No virus found
X-Cam-SpamDetails: Not scanned
cc: freebsd-hackers@freebsd.org
Subject: a serious error in sched_ule.c?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Mar 2004 12:37:20 -0000

Hi, all:

I've been reading sched_ule.c and seem to find a serious error:

in 'sched_slice()':

         * Rationale:
         * KSEs in interactive ksegs get the minimum slice so that we
         * quickly notice if it abuses its advantage.

Then, there is:

        if (!SCHED_INTERACTIVE(kg)) {
                .....
                .....
        } else
                ke->ke_slice = SCHED_SLICE_INTERACTIVE;

Then, at the beginning of the file, there is:

#define SCHED_SLICE_INTERACTIVE         (slice_max)


(slice_max) for interactive KSEs???? Either this is a serious mistake or 
I'm seriously missing sth here.

Thanks,
Bin