From owner-freebsd-gnome@FreeBSD.ORG Fri Nov 10 16:22:45 2006 Return-Path: X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6391016A407 for ; Fri, 10 Nov 2006 16:22:45 +0000 (UTC) (envelope-from mi+mx@aldan.algebra.com) Received: from corbulon.video-collage.com (static-151-204-231-237.bos.east.verizon.net [151.204.231.237]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E77043D70 for ; Fri, 10 Nov 2006 16:22:41 +0000 (GMT) (envelope-from mi+mx@aldan.algebra.com) Received: from mteterin.us.murex.com (mx-broadway [38.98.68.18]) by corbulon.video-collage.com (8.13.8/8.13.8) with ESMTP id kAAGMUbP092541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Nov 2006 11:22:31 -0500 (EST) (envelope-from mi+mx@aldan.algebra.com) From: Mikhail Teterin Organization: Virtual Estates, Inc. To: "Michael Johnson" Date: Fri, 10 Nov 2006 11:22:25 -0500 User-Agent: KMail/1.9.5 References: <200611091924.56887.mi+mx@aldan.algebra.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-u" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200611101122.25719.mi+mx@aldan.algebra.com> X-Virus-Scanned: ClamAV 0.88.4/2185/Fri Nov 10 06:04:49 2006 on corbulon.video-collage.com X-Virus-Status: Clean X-Scanned-By: MIMEDefang 2.43 Cc: gnome@freebsd.org Subject: Re: improving firefox port X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2006 16:22:45 -0000 Π'ΡΤΞΙΓΡ 10 ΜΙΣΤΟΠΑΔ 2006 08:11, Michael Johnson ΞΑΠΙΣΑΧ: > > The following changes to firefox/Makefile and mozilla/Makefile.common, > > along with attached additional patch (firefox/files/patch-sysbz2) allow: > > > > š š š š 1) use of the base system's -lbz2 instead of compiling Mozilla's > > own; > I'm not 100% sure if this is still true (I'll try later today) but > excluding mozilla/modules/zlib will break Sunbird. I'm > all for using system -lbz2/zlib though. That means, Sunbird needs to be fixed :-) I'll try building it here and see. > > š š š š 2) build and run the vendor's self-checks (yes, I'm still at it > > :-) > > I like this, but do you think we should add this to ALL_TARGET instead > of adding a check: target and manually run make check? I think, self-tests should be run -- whenever they are available -- every time after build. People use crazy compiler flags and find numerous other ways to shoot themselves in the foot... Self-test failures are the proverbial canary in the mine, which does wonders to isolate problems. In firefox' case, the available self-testing is rather rudimentary, at the moment, though. It is very quick... -mi