From nobody Mon Jan 26 00:52:38 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dzqkv187Qz6PMll for ; Mon, 26 Jan 2026 00:52:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dzqkt4ZbLz3SPX for ; Mon, 26 Jan 2026 00:52:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769388758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h0WxUY56eX8CPE/bUN98zKcWBPokqqcVQ3buMw6XlOg=; b=jDoiyL4ZWzj+T+zQOtxIOlU13gYXy3b5lxOOs2Hvh8arobWl1NS6cdKF3V80JlQbuTaWkD 1OfU6v//bKRg8cGLcUtoEHtp4Pc7QhRPalpvXSsZJfDed+OgxGW4LPhTtHxpA81Tjtc4F5 jXoxPvl2cFxIwe2ibxf3g/icO8gHt8wupkYUk+tNzegK9NP81vWxaL/jo3cpQDYmVpHI1X wiXXxcnhMUVelIgQAtHX21hjMCk1W1E7AQl2oLyR3OaZs65QhYHVRhtzM4Qk2rtnbnz3Vb gG3gWVd0rUTndva/6IAOOTARiXlri0OHk3PU+LwodQhvz9fZnD5vPtk8mTURAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769388758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h0WxUY56eX8CPE/bUN98zKcWBPokqqcVQ3buMw6XlOg=; b=ZuoE+LthlqODTDgTrqFDbE7xDGkTGj6CUQE3Q0Fgn+LSft+TqxSfi9pIzSCyDcqWcYBdR4 7QyfRrE9K20deN2XN1TSDSbAfdkd6sUvhP+Jqz4OO1ggKRW5H8YVEhkbNdQxaIk1kO1kar 1CWU/o3g3gnp3ztCdR4xCyp5o5F78DIxNYdKDBbx4Tzx3uBZqhK4KC2NW2lLH+CL5miQyl hkf1BS4eDej5cgZ+iUPxrNVbBxErM3YBX/aMgerS+YyTRGFCb77+fUtpPksIgygp2CZTeq XiOLfMT0kSb/XCb4m65DTb5HbwIfCbLk0/K5C/xBVsHISi3rboLPjMcVEOw3Iw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769388758; a=rsa-sha256; cv=none; b=Nb6wSzorCD3NdQuul0waLe/2JNpIZUPklEESqN9fmd0RaNf7c5wFkHR1AOQB+IqkqAvxfV GN08o82un/NFeE4MzzxXTUXoGkkz0o15m81ZNMVRMNgRguNaVtGCvLx35CKmOQzfy4nAGf 83ryYgpCkNbKf7Uzsxn6zl7uHCAqcPVn+s4cpLcJGk1U/kgeFQLSVNGbZeXc+k4LIecmVA tF+RUd8gUEd9lVrEZvnuyayJuQ/ROTcgtks3+ndyRyf0e9Y67z3NvSt0eZ4+tAjCyw8iAW H7JU9reMJPQ1Y5UZuAJATfQFOBaj9jvbjPBSinc+s/7/gjvJ79g8LC99eD1bqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dzqkt2PTszyML for ; Mon, 26 Jan 2026 00:52:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 813c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 26 Jan 2026 00:52:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: a3b3be585f7e - stable/15 - linuxkpi: Avoid a potential null pointer dereference in an error path List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a3b3be585f7e0cbb9736399172aa72f06161819b Auto-Submitted: auto-generated Date: Mon, 26 Jan 2026 00:52:38 +0000 Message-Id: <6976bad6.813c.5f145943@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a3b3be585f7e0cbb9736399172aa72f06161819b commit a3b3be585f7e0cbb9736399172aa72f06161819b Author: Mark Johnston AuthorDate: 2026-01-15 13:51:17 +0000 Commit: Mark Johnston CommitDate: 2026-01-26 00:51:44 +0000 linuxkpi: Avoid a potential null pointer dereference in an error path Reported by: Kevin Day Reviewed by: bz, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54672 (cherry picked from commit aa1eb623389008c95b897976f4d28a7fe0acd93c) --- sys/compat/linuxkpi/common/src/linux_firmware.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_firmware.c b/sys/compat/linuxkpi/common/src/linux_firmware.c index 12658df5ce83..0c6d855501ef 100644 --- a/sys/compat/linuxkpi/common/src/linux_firmware.c +++ b/sys/compat/linuxkpi/common/src/linux_firmware.c @@ -66,7 +66,8 @@ _linuxkpi_request_firmware(const char *fw_name, const struct linuxkpi_firmware * uint32_t flags; if (fw_name == NULL || fw == NULL || dev == NULL) { - *fw = NULL; + if (fw != NULL) + *fw = NULL; return (-EINVAL); }