From owner-svn-src-head@FreeBSD.ORG Wed Apr 15 19:04:29 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17CF595F; Wed, 15 Apr 2015 19:04:29 +0000 (UTC) Received: from mailrelay102.isp.belgacom.be (mailrelay102.isp.belgacom.be [195.238.20.129]) by mx1.freebsd.org (Postfix) with ESMTP id 37E473A6; Wed, 15 Apr 2015 19:04:27 +0000 (UTC) X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=+BsAzE94k0WpM8AtezFGaEXBVpw1lpSE4R7UN5Nfg4g= c=1 sm=2 a=6I5d2MoRAAAA:8 a=m_g2NoT2XDoVAkJkzFEA:9 a=CjuIK1q_8ugA:10 a=A0Z3edhQMQfFuqFnjtcA:9 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BmBgD6tS5V/zOwsFtcgwyBIgzNUQKBO00BAQEBAQF+hCEBAQRWIxALGAkaCw8qHgYTiC4BxRoBAQEBAQEEAQEBAQEBHIsrhHwHhC0BBJMGiCeLYokYIoIDHBSBPjwxgkMBAQE Received: from 51.176-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.176.51]) by relay.skynet.be with ESMTP; 15 Apr 2015 21:04:25 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id t3FJ4OPU021906; Wed, 15 Apr 2015 21:04:24 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Wed, 15 Apr 2015 21:04:24 +0200 From: Tijl Coosemans To: Adrian Chadd Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r281550 - in head: . bin/csh contrib/smbfs/include/netsmb contrib/smbfs/lib/smb include lib/libarchive lib/libc/iconv lib/libc/locale lib/libiconv_modules/BIG5 lib/libiconv_modules/DECH... Message-ID: <20150415210424.2fc38e39@kalimero.tijl.coosemans.org> In-Reply-To: References: <201504150909.t3F99LFB048690@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Jl84pmqTHGsHqD0th0oIFx=" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 19:04:29 -0000 --MP_/Jl84pmqTHGsHqD0th0oIFx= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wed, 15 Apr 2015 11:29:19 -0700 Adrian Chadd wrote: > cc1: warnings being treated as errors > /usr/home/adrian/work/freebsd/embedded/head/src/bin/csh/../../contrib/tcsh/sh.func.c: > In function 'iconv_catgets': > /usr/home/adrian/work/freebsd/embedded/head/src/bin/csh/../../contrib/tcsh/sh.func.c:2599: > warning: passing argument 2 of 'dl_iconv' from incompatible pointer > type Does "embedded" mean that WITHOUT_ICONV is defined? Can you try the attached patch? --MP_/Jl84pmqTHGsHqD0th0oIFx= Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=iconv.patch Index: bin/csh/iconv_stub.h =================================================================== --- bin/csh/iconv_stub.h (revision 281561) +++ bin/csh/iconv_stub.h (working copy) @@ -30,7 +30,7 @@ #define _ICONV_H_ typedef void *iconv_t; -typedef size_t dl_iconv_t(iconv_t, const char **, size_t *, char **, size_t *); +typedef size_t dl_iconv_t(iconv_t, char **, size_t *, char **, size_t *); typedef int dl_iconv_close_t(iconv_t); extern iconv_t dl_iconv_open(const char *, const char *); --MP_/Jl84pmqTHGsHqD0th0oIFx=--