From owner-cvs-src@FreeBSD.ORG Wed May 23 16:29:47 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1245B16A469; Wed, 23 May 2007 16:29:47 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.freebsd.org (Postfix) with ESMTP id A924713C487; Wed, 23 May 2007 16:29:46 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id 1D6E4678B; Wed, 23 May 2007 20:29:45 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id EF916677F; Wed, 23 May 2007 20:29:44 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id l4NGP6Nj001392; Wed, 23 May 2007 20:25:06 +0400 (MSD) (envelope-from ru) Date: Wed, 23 May 2007 20:25:06 +0400 From: Ruslan Ermilov To: Konstantin Belousov Message-ID: <20070523162506.GA82428@rambler-co.ru> References: <200705231545.l4NFjqvV074354@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline In-Reply-To: <200705231545.l4NFjqvV074354@repoman.freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) X-Virus-Scanned: No virus found Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files.amd64 files.i386 files.pc98 src/sys/modules/linux Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2007 16:29:47 -0000 --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 23, 2007 at 03:45:52PM +0000, Konstantin Belousov wrote: > kib 2007-05-23 15:45:52 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/conf files.amd64 files.i386 files.pc98=20 > sys/modules/linux Makefile=20 > Log: > Fix the dependency for the linux_support.s, explicitely add linux_assym= =2Eh. > =20 > Reported by: rwatson > In collaboration with: rdivacky > Sponsored by: Google SoC 2007 > =20 > Revision Changes Path > 1.103 +2 -1 src/sys/conf/files.amd64 > 1.576 +2 -1 src/sys/conf/files.i386 > 1.354 +2 -1 src/sys/conf/files.pc98 > 1.72 +1 -1 src/sys/modules/linux/Makefile >=20 These files would better have an .S extension as they contain preprocessor macros. From gcc.info: : For any given input file, the file name suffix determines what kind of : compilation is done: [...] :=20 : `FILE.s' : Assembler code. :=20 : `FILE.S' : Assembler code which must be preprocessed. Our standard make(1) rules know about this: : $ touch a.s; make -n a.o; rm a.s : as -o a.o a.s : $ touch a.S ; make -n a.o ; rm a.S : cc -O2 -fno-strict-aliasing -pipe -c a.S This doesn't matter much for the kernel build (it provides its own rules to build from .[Ss]), but makes a difference for a module build, if the latter needs to compile some of the assembly. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGVGriqRfpzJluFF4RApd8AJ4xNqnSlFQ27RRYsxOHe+MOCt3gvQCePqr6 7swWGJ8krdhm0tQuIcRTh1E= =dp5h -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--