From owner-svn-src-head@FreeBSD.ORG Tue Oct 15 14:57:18 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6AEBF2D4 for ; Tue, 15 Oct 2013 14:57:18 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 063DD2B74 for ; Tue, 15 Oct 2013 14:57:17 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=date:from:to :cc:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=sweb; b=GPse0r6nO7Z9eT8b2SI1OqTAWu4ZOzIxG ZQeKp7xTY0TPFEMe1lgMAYOUtPRZgQJs2GxwAOEy8V/c+vmeWv1dfmL5O+6nddnS uhsQAZudndoGxZ9X5w8IHPCxEllkzfylXWNCj263CkxCaINeWVJdBVSfClkS+HpX svkPdFZc34= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=date:from :to:cc:subject:message-id:references:mime-version:content-type :in-reply-to; s=sweb; bh=FopGSdci2BMI2P9eAJ7HEnPzWq1g8x+UBr/Vu2P hzMA=; b=nIYn5/XoHa4wbxyWa+WC+xGDyPXcWQepnq7SfCX2D5RUIl1wKgRlUDC v10DP3kn2EkrLFPewGmMeQFAZi9UYWojobyJjPWa6FCbObGrGS2Gs2EnV4hCM+PN Jd9iW0bmVJ1Z8RG6tVBhQsdy1PBQ4dlldJQU0azpcHrwVIgnldtE= Received: (qmail 16636 invoked from network); 15 Oct 2013 09:50:34 -0500 Received: from unknown (HELO admin.xzibition.com) (bryan@shatow.net@173.160.118.90) by sweb.xzibition.com with ESMTPA; 15 Oct 2013 09:50:34 -0500 Date: Tue, 15 Oct 2013 09:50:32 -0500 From: Bryan Drewery To: Devin Teske Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Message-ID: <20131015145032.GD98118@admin.xzibition.com> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mJm6k4Vb/yFcL9ZU" Content-Disposition: inline In-Reply-To: <201310112041.r9BKfZeT002056@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 14:57:18 -0000 --mJm6k4Vb/yFcL9ZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 11, 2013 at 08:41:35PM +0000, Devin Teske wrote: > Author: dteske > Date: Fri Oct 11 20:41:35 2013 > New Revision: 256343 > URL: http://svnweb.freebsd.org/changeset/base/256343 >=20 > Log: > Add zfsboot module as an option for automatic configuration. Default is > to run interactively but it can be scripted too (optinally completely > non-interactive). Currently supports GELI and all ZFS vdev types. Also > performs validation on selections/settings providing error messages if > necessary, explaining (in plain language) what the issue is. Currently > the auto partitioning of naked disks only supports GPT and MBR (VTOC8 > pending for sparc64), so is only available for i386/amd64 install. > =20 > Submitted by: Allan Jude , myself > Reviewed by: Allan Jude > Approved by: re (glebius) >=20 > Added: > head/usr.sbin/bsdinstall/scripts/zfsboot (contents, props changed) > Modified: > head/usr.sbin/bsdinstall/bsdinstall > head/usr.sbin/bsdinstall/scripts/Makefile > head/usr.sbin/bsdinstall/scripts/auto > head/usr.sbin/bsdinstall/scripts/config >=20 > +# Should we use gnop(8) to configure a transparent mapping to 4K sectors? > +# > +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=3D1} I believe this trick is no longer needed after r254591. > *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** =2E.. > +# Default name for the boot environment parent dataset > +# > +: ${ZFSBOOT_BEROOT_NAME:=3Dbootenv} =2E.. > + # Set bootfs property > + zpool set bootfs=3D"$poolname/$ZFSBOOT_BEROOT_NAME/$ZFSBOOT_BOOTF= S_NAME" \ > + "$poolname" || return $FAILURE Can you please make ZFSBOOT_BEROOT_NAME be ROOT by default? This is what sysutils/beadm, OpenSolaris/Illumos beadm, and I believe PC-BSD all expect and use as well. --mJm6k4Vb/yFcL9ZU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQJ8BAEBCgBmBQJSXVY2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzNkZFQkU5OTJGNTI4MERGNDgxMTM2MkE2 RTc4MkFDMDNDOUIwQ0Y5AAoJEG54KsA8mwz5WWEP/jO3OgFLdBCc7L/nnNSVMbOr iJF0lZwAdHXDFSF9IPwxkF+WdNPycVUzV0MDv/YIREwGy2wdH/VJQZt8JX11Gc+x TtWPDtHsD6jVAOErUwD34vK/V9mPktLDrW9u4hhdNqQkf8S8fgHQcx3BP6OBagRc 3onpSehU3n9nbEGIch/inQv7S9QjR9yt1NB/GDvOFc6AqsdawyxMLS8mZvyUIaRe S5INpMwMGeLLSTr+h6GmtjqeQ7Z7yGXcQc+e932TkA1nf0n4Eh4lzrvpZpYNSn0i G+69A3Hs2KpPWCMj5HJPMG7rzBH/wKCrE3jCWf5V3L5nTEhhy3yYBcjkhnWJxcx4 Z185juqLUagF45vEARXOVveMz+/YLBrbS6RisV1rp2DooiKVQ38dryTCQ4HUknLp fQpB2wZxV6arGREy6cts9fte0L3L9l07NzXfp+2Jo92We+59mq2kjfn1RcdBJolD 82iR20pjRaBgpwlFSg1VDGXrOFLeOfT/le3uEcSlim9P4DUguJ+xx9XMAFVLk0Fz BTKQ2q8SaCrS5WNa1vbuFftRzkJVnzGQ8Sc51rNHRVL1NroTlXuLDcikTvSgR+Ck tCEczBITHsT+i1EXn79o1INsOkKRuQ6YiC3Wp0plMkgKYCz1CyhlaQFvU1gmnhDo +Chf0CTj/O6s23rdMLFS =t/mk -----END PGP SIGNATURE----- --mJm6k4Vb/yFcL9ZU--