From owner-freebsd-current Thu Apr 11 22:27:22 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA23132 for current-outgoing; Thu, 11 Apr 1996 22:27:22 -0700 (PDT) Received: (from pst@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id WAA23125 for current; Thu, 11 Apr 1996 22:27:19 -0700 (PDT) Date: Thu, 11 Apr 1996 22:27:19 -0700 (PDT) From: Paul Traina Message-Id: <199604120527.WAA23125@freefall.freebsd.org> To: current Subject: feedback sought on proposed change to netstart Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Currently /etc/netstart evaluates /etc/start_if. if the file exists, and THEN does any standard ifconfig commands if defined. This seems very backwards and broken to me. Here's my justification: Basic stuff can be done by executing the commands in sysconfig, just like we always do. /etc/start_if. is for additional stuff or exceptions, such as configuring aliases. It makes sense to set up the interface, first, and then get fancy with it. Here's the change, 24 hours to comment: Index: netstart =================================================================== RCS file: /home/ncvs/src/etc/netstart,v retrieving revision 1.44 diff -c -r1.44 netstart *** netstart 1996/04/06 09:24:48 1.44 --- netstart 1996/04/12 05:23:48 *************** *** 40,50 **** # Set up all the network interfaces, calling startup scripts if needed for ifn in ${network_interfaces}; do if [ -e /etc/start_if.${ifn} ]; then . /etc/start_if.${ifn} ${ifn} fi - eval ifconfig_args=\$ifconfig_${ifn} - ifconfig ${ifn} ${ifconfig_args} ifconfig ${ifn} done --- 40,50 ---- # Set up all the network interfaces, calling startup scripts if needed for ifn in ${network_interfaces}; do + eval ifconfig_args=\$ifconfig_${ifn} + ifconfig ${ifn} ${ifconfig_args} if [ -e /etc/start_if.${ifn} ]; then . /etc/start_if.${ifn} ${ifn} fi ifconfig ${ifn} done