From owner-freebsd-hackers@FreeBSD.ORG Fri Jun 15 03:22:46 2012 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 11D59106566B for ; Fri, 15 Jun 2012 03:22:46 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id C86B98FC19 for ; Fri, 15 Jun 2012 03:22:45 +0000 (UTC) Received: by obcni5 with SMTP id ni5so4264815obc.13 for ; Thu, 14 Jun 2012 20:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Bb8JkB5vnOc7VKwPEMyef5YqZbg/zkHtwY0gRGTmKKw=; b=i56MFQaPtmrcsAx++avIr9icaMqe5n8h6NTtV2TriiCKufMPHutSwsg6gCRoGv2LU8 A2ntNVb0q5Z1aGTtVUhxdtvD+IikKNvQFzjj7UPoOV5d5u4tqDR7VDC3heaWj5VwIDJ4 421bkwFW9YlXsYmKIvdtXO7wEvUGCasPWVB/d4as8Wk3tCLAw/8vDo0TLy+ywLeRIDWN wO3eyGSG5KzLsGtxGcZN0LC7YPhHds/snNc20toTvG8uzpo9uGNEEvOceJnPfVv4IQPN 7VbtzYTAmNg4Hd2K4ANgH7/7T91W5cN4YskFKE/MIiu9bwAqKc7UN+SmsAHfk5cCWvuD Mxtg== MIME-Version: 1.0 Received: by 10.182.40.5 with SMTP id t5mr4240535obk.68.1339730565405; Thu, 14 Jun 2012 20:22:45 -0700 (PDT) Received: by 10.76.98.77 with HTTP; Thu, 14 Jun 2012 20:22:45 -0700 (PDT) In-Reply-To: <4FDAA07C.3030509@gentoo.org> References: <4FDA3364.2020102@gentoo.org> <2073f978e4954a989754752f4da71f9a@HUBCAS2.cs.stonybrook.edu> <4FDA9732.9020804@gentoo.org> <20120614222432.24e52fee@kan.dyndns.org> <4FDAA07C.3030509@gentoo.org> Date: Thu, 14 Jun 2012 20:22:45 -0700 Message-ID: From: Garrett Cooper To: Richard Yao Content-Type: text/plain; charset=ISO-8859-1 Cc: "gentoo-bsd@lists.gentoo.org" , "hackers@FreeBSD.org" Subject: Re: Import crt{begin,end}.S from NetBSD X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2012 03:22:46 -0000 On Thu, Jun 14, 2012 at 7:39 PM, Richard Yao wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 06/14/12 22:24, Alexander Kabaev wrote: >> On Thu, 14 Jun 2012 22:00:18 -0400 Richard Yao >> wrote: >> >> >>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> >>> On 06/14/12 20:51, Alexander Kabaev wrote: >>>> On Thu, 14 Jun 2012 14:54:28 -0400 Richard Yao >>>> wrote: >>>> >>>>> NetBSD has replacements for GCC's crt{begin,end}.S: >>>>> >>>>> http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/csu/arch/?only_with_tag=MAIN >>>>> >>>>> >>>>> > This would complement compiler-rt and libstdc++. We intend to >>>>> import it in downstream Gentoo FreeBSD. >>>>> >>>>> Could this be imported into FreeBSD-CURRENT? >>>> >>>> Apart from licensing, what others reasons are there to do >>>> that? >>>> >>> These components should not be tied to a specific compiler. If >>> GCC is going to be deprecated, then they should be replaced. >> >>> Anyway, having this tied to GCC has caused headaches for Clang >>> integration in Gentoo. In particular, we let the user pick the >>> toolchain that he uses, so we cannot place GCC's crt{begin,end}.o >>> in the same location that FreeBSD uses. This makes it difficult >>> for Clang to find the correct crt{begin,end}.o. We will likely >>> import the NetBSD crt{begin,end}.S code to rectify this, but it >>> would be preferable to do this in upstreamFreeBSD. >> >> Assuming NetBSD version is a direct plugin for crtbegin/end >> provided by GCC, I see no reason why we cannot do that. Are you are >> willing to do the work and submit the patch, or would like to wait >> for someone on our side? > > Gentoo FreeBSD is currently based on FreeBSD 9-RELEASE. I plan to do > the work to import this downstream within the week, but I am not > running CURRENT. It might be necessary to iterate on the patches > before they can be merged. When I have them, should I file a PR or > post them to the list? File a PR, post a link to the PR on a list / to devs generally is the best way to go. Thanks! -Garrett