From owner-freebsd-bugs@FreeBSD.ORG  Thu Dec 18 11:30:25 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3052116A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 18 Dec 2003 11:30:25 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 46F4A43D36
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 18 Dec 2003 11:30:24 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	hBIJUOFR062110	for <freebsd-bugs@freefall.freebsd.org>;
	Thu, 18 Dec 2003 11:30:24 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBIJUOwW062109;
	Thu, 18 Dec 2003 11:30:24 -0800 (PST)
	(envelope-from gnats)
Date: Thu, 18 Dec 2003 11:30:24 -0800 (PST)
Message-Id: <200312181930.hBIJUOwW062109@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dan Hulme <d@diefree.com>
Subject: Re: misc/60352: [PATCH] buildworld fails in sysinstall if terminfo
 database in /usr/share/misc/terminfo
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dan Hulme <d@diefree.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2003 19:30:25 -0000

The following reply was made to PR misc/60352; it has been noted by GNATS.

From: Dan Hulme <d@diefree.com>
To: freebsd-gnats-submit@FreeBSD.org, d@diefree.com
Cc:  
Subject: Re: misc/60352: [PATCH] buildworld fails in sysinstall if terminfo
 database in /usr/share/misc/terminfo
Date: Thu, 18 Dec 2003 11:27:06 -0800

 By way of explanation, this code returns identical output as the 
 original rtermcap.c, except in the case of an existing terminfo.  In 
 that case, this code returns to correct output (i.e., the same as if 
 there were no terminfo db), whereas the old code failed silently 
 (printing nothing).
 
 The choice to strip double colons and tabs was made not by necessity (I 
 am not certain whether it is important or not, but I imagine the target 
 program would ignore them), but rather to produce identical output.  
 This way, there can be no doubt that this code should function as a 
 drop-in replacement for the old code.
 
 I tested this code and the resulting makedevs.c was identical in size 
 and content to that created with the original code.  Again, the only 
 difference is when a terminfo db exists, in which case *only* this code 
 works.
 
 -Dan