From owner-svn-ports-all@freebsd.org Sat Jan 2 20:17:24 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 318E54DDEC3; Sat, 2 Jan 2021 20:17:24 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7Y8f6h3mz4vST; Sat, 2 Jan 2021 20:17:22 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id E1A9633E50; Sat, 2 Jan 2021 15:17:21 -0500 (EST) Received: from [192.168.1.5] (77.118.226.34.wireless.dyn.drei.com [77.118.226.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 2388333E48; Sat, 2 Jan 2021 15:17:21 -0500 (EST) Date: Sat, 2 Jan 2021 21:17:16 +0100 (CET) From: Gerald Pfeifer To: "Sergey A. Osokin" cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r522069 - head/databases/redis-devel In-Reply-To: <202001042339.004NdRpX083271@repo.freebsd.org> Message-ID: References: <202001042339.004NdRpX083271@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4D7Y8f6h3mz4vST X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-3.30 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.68.5.143:from]; FREEFALL_USER(0.00)[gerald]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_ZRD(0.00)[209.68.5.143:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-ports-all,svn-ports-head] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 20:17:24 -0000 On Sat, 4 Jan 2020, Sergey A. Osokin wrote: > +.if ${ARCH} == i386 && ! ${CFLAGS:M-march=*} > +# Needed for __atomic_fetch_add_8 > +USE_GCC= yes > +CFLAGS+= -march=i586 > .endif This has been a while ago, yet I noticed it is still in place. Are you sure clang does not provide that? GCC 4.2 should not be an issue on i386 any more since FreeBSD 11 is already on clang. And the default for current GCC on FreeBSD on i386 already is i586 since commit 01a0467e237b69e02f5467babfe2d235c8c68b68 Author: Gerald Pfeifer Date: Sun Nov 15 20:03:24 2015 +0000 freebsd.h (SUBTARGET32_DEFAULT_CPU): Change to i586. * config/i386/freebsd.h (SUBTARGET32_DEFAULT_CPU): Change to i586. Remove support for FreeBSD 5 and earlier. so the CFLAGS line definitely should not be required. Gerald