From owner-freebsd-ports@freebsd.org Mon Oct 29 08:25:23 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F24410CEC88 for ; Mon, 29 Oct 2018 08:25:23 +0000 (UTC) (envelope-from jongsung.kim@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id ECDFC84892 for ; Mon, 29 Oct 2018 08:25:22 +0000 (UTC) (envelope-from jongsung.kim@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id B283A10CEC87; Mon, 29 Oct 2018 08:25:22 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7707B10CEC86 for ; Mon, 29 Oct 2018 08:25:22 +0000 (UTC) (envelope-from jongsung.kim@gmail.com) Received: from mail-it1-x136.google.com (mail-it1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 108CC8488F; Mon, 29 Oct 2018 08:25:22 +0000 (UTC) (envelope-from jongsung.kim@gmail.com) Received: by mail-it1-x136.google.com with SMTP id k206-v6so8489753ite.0; Mon, 29 Oct 2018 01:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cDe2T2dZ0Emn+tAjk4rdNfdKRpPUCs/k2nIXquso9VI=; b=W7mGYjj74sVyzSqTaplln5lGK22fKTjvq151qgKwWYrWePsjNtJSg4qfTXd6+tSq1Q +GHaFXvhTLAXR5Of1mg6KML8S2WGd0CTQFEse80pZnsQT4ejgApeTj1Dm6ndz6tpCuuc 4QkDFHA1Bh1aG89roAXBJFFPPwFaG+uy8+hgVB5FYRyN/rcve5KicxsHhfJFK5NHbHxA UZkFbRcVyKtMW6Mnqn1w4a7M/GhNZqmogIJ6uiZi7xW1DNdWXt2bITpnON/C0xybVqHc MtrQrAPS2nAv+88S1G8iwTWsT+8h6BZMUiUKTjnVh+6jO5qCiRKlXkE49vt+aNFPFxTt xv5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cDe2T2dZ0Emn+tAjk4rdNfdKRpPUCs/k2nIXquso9VI=; b=M50sDgsjJFX2IMYuUWssHCHmtl0Vd7kmFJUqb16QMG+Gy6UL5oeBAC6emu46nbNnoi J1RmN6bb6eTSYAfDr723cAXUVl8USxtjjtLG8KThiHC9LsZ6RqiszarkhqDRiBWnYiy0 Jm+YrJnTK85WZQdmWmBQ00DSFJ5/vTY8SvBJBhDVEYSEVmx79QWPtl1xSZfjoxUSgWR0 ItM85E331p4dWpClyritgdikGAO7DBjCKBi3vKmkqjJJs+MzeKcnEMy4JL9MzOXyhaTl ArRuv7iua16bpfpeiTKT8tBvKBPrs5GB/iU5wVyihhiyC7rMZxhi1JhPU6qwAZZwiu37 FhAA== X-Gm-Message-State: AGRZ1gISA7kpNxnXerA63G4LvOS+FEDdtubO3U+8vgNtL9urluzy25/R uLrpgfBQrHFeCzoe9UlJ7boPknuuBbo7OPH8OdowYRE5 X-Google-Smtp-Source: AJdET5ceQAGeoEkwxD5aNK2ApZM83SRU1Ld38XzfMxUIj3y6J0NOSlIRqeUtrn92HL6MvL7rcjEG7uzB6GO7nHjNT3E= X-Received: by 2002:a24:bc47:: with SMTP id n68-v6mr9963874ite.102.1540801520972; Mon, 29 Oct 2018 01:25:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?6rmA7KKF7ISx?= Date: Mon, 29 Oct 2018 17:25:09 +0900 Message-ID: Subject: Re: multimedia/tvheadend cannot service live TV after upgrading v4.2.7 To: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= Cc: ports@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 08:25:23 -0000 We need to re-apply my second patch related to sendfile syscall too. The current tvheadend can't service recorded media properly. And I have another suggestion about web UI. I have seen abnormal behavior in the EPG tab. The entire program list disapears when I click "Reset All" button. This happens also when I type any search text and delete all. Linux tvheadend users don't suffer this problem. However, I found a way to fix this problem by modifying src/webui/static/app/epg.js: diff --git a/src/webui/static/app/epg.js b/src/webui/static/app/epg.js index 650ac9202..d00b76557 100644 --- a/src/webui/static/app/epg.js +++ b/src/webui/static/app/epg.js @@ -1167,12 +1167,10 @@ tvheadend.epg =3D function() { var value =3D c.getValue(); if (value.length < 1) - value =3D null; - - if (epgStore.baseParams.title !=3D=3D value) { + delete epgStore.baseParams.title; + else if (epgStore.baseParams.title !=3D=3D value) epgStore.baseParams.title =3D value; - epgView.reset(); - } + epgView.reset(); }); epgFilterFulltext.on('check', function(c, value) { But I don't know whether it's correct way and why it works, because I totally don't know about web programming. Can anybody review this patch? 2018=EB=85=84 10=EC=9B=94 25=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 8:49, = Bernhard Fr=C3=B6hlich =EB=8B=98=EC=9D=B4 =EC=9E=91=EC= =84=B1: > On Tue, Oct 23, 2018 at 5:53 AM =EA=B9=80=EC=A2=85=EC=84=B1 wrote: > > > > Hi decke, > > tvheadend v4.2.7 has a merged commit 3895c923a FreeBSD: Fix recv proble= m > if no data received, which touches my previous merged commit 0d5c8efee tc= p: > fix tcp_socket_dead() for FreeBSD. It makes the FreeBSD port of tvheadend > unable to service live TV, and reverted from the mainline. (f08bbef11 > Revert "FreeBSD: Fix recv problem if no data received.") Please apply thi= s > reverting patch: > > > > commit f08bbef11c77a6a81d4e2bf974e36e54b0cd14d6 > > Author: Jaroslav Kysela > > Date: Tue Oct 16 16:51:00 2018 +0200 > > > > Revert "FreeBSD: Fix recv problem if no data received." > > > > This reverts commit 3895c923a3a959da05080831b8146c09ed143b00. > > > > diff --git a/src/tcp.c b/src/tcp.c > > index d15b4381f..5349784a4 100644 > > --- a/src/tcp.c > > +++ b/src/tcp.c > > @@ -454,11 +454,8 @@ tcp_socket_dead(int fd) > > if (err) > > return -err; > > #ifdef PLATFORM_FREEBSD > > - err =3D recv(fd, NULL, 0, MSG_PEEK | MSG_DONTWAIT); > > - if (err < 0) > > + if (recv(fd, NULL, 0, MSG_PEEK | MSG_DONTWAIT) < 0) > > return -errno; > > - else if (err =3D=3D 0) > > - return -EIO; > > #else > > if (recv(fd, NULL, 0, MSG_PEEK | MSG_DONTWAIT) =3D=3D 0) > > return -EIO; > > > > Thank you > > JS > > Thanks! Committed in r482966. > > https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D482966 > > -- > Bernhard Froehlich > http://www.bluelife.at/ >