From owner-svn-src-stable-11@freebsd.org Thu Aug 16 11:37:50 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00F8E1086DD2; Thu, 16 Aug 2018 11:37:50 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A12847D0E7; Thu, 16 Aug 2018 11:37:49 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 2DD271CFEB; Thu, 16 Aug 2018 11:37:49 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f53.google.com with SMTP id a134-v6so3153780lfe.6; Thu, 16 Aug 2018 04:37:49 -0700 (PDT) X-Gm-Message-State: AOUpUlGcV7jdcLJH39hhmx/fYRJe48ngRj9m/Rg3oMbdUd0u7M8KT4DG 6liFYvlcBZNN98K4HVKt3JoDl8mhw6a9fUSEmMM= X-Google-Smtp-Source: AA+uWPw4u+We9XRkfJC4RDoK9ZmHMUU/zsYqgSv0/XPONYzjo0ZYoORej9UhgM2B/yoZx8NghJZIAbAMEEjbqDX4sGo= X-Received: by 2002:a19:5154:: with SMTP id f81-v6mr1536499lfb.55.1534419467680; Thu, 16 Aug 2018 04:37:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Thu, 16 Aug 2018 04:37:27 -0700 (PDT) In-Reply-To: <20180816092928.GA49543@FreeBSD.org> References: <201808152026.w7FKQGBN049627@pdx.rh.CN85.dnsmgr.net> <1534364937.1466.11.camel@freebsd.org> <20180816092928.GA49543@FreeBSD.org> From: Kyle Evans Date: Thu, 16 Aug 2018 06:37:27 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337826 - stable/11/bin/ls To: Alexey Dokuchaev Cc: Warner Losh , Ian Lepore , src-committers , Ed Maste , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-11@freebsd.org, Adam Weinberger , "Rodney W. Grimes" , Kyle Evans Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Thu, 16 Aug 2018 12:33:28 +0000 X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 11:37:50 -0000 On Thu, Aug 16, 2018 at 4:29 AM, Alexey Dokuchaev wrote: > On Wed, Aug 15, 2018 at 02:32:54PM -0600, Warner Losh wrote: >> On Wed, Aug 15, 2018 at 2:28 PM, Ian Lepore wrote: >> > On Wed, 2018-08-15 at 13:26 -0700, Rodney W. Grimes wrote: >> > > > >> > > > Will backing out the MFC and leaving this a 12.0 feature end this? >> > > =( >> > > >> > > Sadly no, as the person responded with that reaction when >> > > they installed 12.0-ALPHA :-(. >> > >> > So one whiner can demand of the project that any new feature be removed >> > before a new release is made? >> >> This is a good change. > > It might be a good change, but it's also very controversial. Traditionally, > ls(1) was colorless by default. I don't mind adding COLORTERM (albeit see > no reason for this: those who wanted colors could always added -G option to > their ls(1) alias or set CLICOLOR variable), but it should definitely lean > to being colorless unless explicitly asked. As Rod had pointed out, colors > mean you now have to stat(2) file listed which is a significant performance > impact. > > So yeah, there are reasons why people are so fussed about it. Why fix > something that ain't broken? Why break POLA? > Please read the diff before responding with stuff like this and your below e-mail. It was already long backed out by the time you responded, and it behaves exactly as you mention in your first paragraph -- COLORTERM must be set to get color, with the caveat that people apparently don't realize their terminal modifies their environment and sets COLORTERM in addition to setting TERM appropriately. Agreed on the documentation, though there's a lot of other things that also invoke the stat(2). Thanks, Kyle Evans