From owner-svn-src-all@FreeBSD.ORG Mon Feb 9 16:03:41 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 412151065670; Mon, 9 Feb 2009 16:03:41 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:203:6dff:fe1a:4ddc]) by mx1.freebsd.org (Postfix) with ESMTP id BB3EA8FC19; Mon, 9 Feb 2009 16:03:40 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from [10.1.1.53] ([10.1.1.53]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id n19G3m9x042646 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 9 Feb 2009 11:03:48 -0500 (EST) (envelope-from rrs@lakerest.net) DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail; t=1234195429; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type: Content-Transfer-Encoding:Mime-Version:Subject:Date:References: X-Mailer; b=Ce2pTUjd8RBs4iUtWKPRfoA2W5AUcSA1Ksl2Zm9AeyIcvU9SGSJhl6r KCEnLYt8ArZ5Ve5M8wBS8qPgiiN22OA== Message-Id: <32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC@lakerest.net> From: Randall Stewart To: Chagin Dmitry , Paolo Pisati In-Reply-To: <20090209124141.GA2071@dchagin.static.corbina.ru> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Mon, 9 Feb 2009 11:03:38 -0500 References: <200902091142.n19BgNnb059032@svn.freebsd.org> <20090209124141.GA2071@dchagin.static.corbina.ru> X-Mailer: Apple Mail (2.930.3) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188388 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2009 16:03:42 -0000 Hmm.. My guess is it has to do with the NAT stuff that Paolo is working on. Basically the ipfw/nat is becoming SCTP aware and I believe we made the sctp_crc32c routines public so that he could access them. Paolo: maybe you need to include and then do some sort of #ifdef SCTP #endif Around the csum calls int crc32?? R On Feb 9, 2009, at 7:41 AM, Chagin Dmitry wrote: > On Mon, Feb 09, 2009 at 11:42:23AM +0000, Randall Stewart wrote: >> Author: rrs >> Date: Mon Feb 9 11:42:23 2009 >> New Revision: 188388 >> URL: http://svn.freebsd.org/changeset/base/188388 >> >> Log: >> Fix minor spacing problem found by s9indent from last >> commit. >> >> Modified: >> head/sys/netinet/sctp_crc32.c >> >> Modified: head/sys/netinet/sctp_crc32.c >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- head/sys/netinet/sctp_crc32.c Mon Feb 9 11:41:54 2009 (r188387) >> +++ head/sys/netinet/sctp_crc32.c Mon Feb 9 11:42:23 2009 (r188388) >> @@ -729,10 +729,11 @@ sctp_finalize_crc32(uint32_t crc32c) >> #endif >> return (crc32c); >> } >> + >> #else >> uint32_t >> -update_crc32(uint32_t crc32c, unsigned char *buffer, unsigned int >> length) { >> - >> +update_crc32(uint32_t crc32c, unsigned char *buffer, unsigned int >> length) >> +{ >> return (0); >> } >> >> @@ -741,6 +742,7 @@ sctp_finalize_crc32(uint32_t crc32c) >> { >> return (0); >> } >> + >> #endif /* !defined(SCTP_WITH_NO_CSUM) */ >> >> #if defined(SCTP_WITH_NO_CSUM) > > > What would you say about this? (I do not have SCTP option in the > kernel config) > > linking kernel.debug > alias_sctp.o(.text+0x1744): In function `TxAbortErrorM': > /work/pub/head/sys/netinet/libalias/alias_sctp.c:946: undefined > reference to `update_crc32' > alias_sctp.o(.text+0x174b):/work/pub/head/sys/netinet/libalias/ > alias_sctp.c:946: undefined reference to `sctp_finalize_crc32' > *** Error code 1 > > Stop in /tank/obj/work/pub/head/sys/YOY. > *** Error code 1 > > > -- > Have fun! > chd > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)