From owner-svn-soc-all@freebsd.org  Wed Aug 10 17:25:11 2016
Return-Path: <owner-svn-soc-all@freebsd.org>
Delivered-To: svn-soc-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8F6EBB5E41
 for <svn-soc-all@mailman.ysv.freebsd.org>;
 Wed, 10 Aug 2016 17:25:11 +0000 (UTC)
 (envelope-from iateaca@FreeBSD.org)
Received: from socsvn.freebsd.org (socsvn.freebsd.org
 [IPv6:2001:1900:2254:206a::50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AC5CD107A
 for <svn-soc-all@FreeBSD.org>; Wed, 10 Aug 2016 17:25:11 +0000 (UTC)
 (envelope-from iateaca@FreeBSD.org)
Received: from socsvn.freebsd.org ([127.0.1.124])
 by socsvn.freebsd.org (8.15.2/8.15.2) with ESMTP id u7AHPB2j009264
 for <svn-soc-all@FreeBSD.org>; Wed, 10 Aug 2016 17:25:11 GMT
 (envelope-from iateaca@FreeBSD.org)
Received: (from www@localhost)
 by socsvn.freebsd.org (8.15.2/8.15.2/Submit) id u7AHPBaZ009223
 for svn-soc-all@FreeBSD.org; Wed, 10 Aug 2016 17:25:11 GMT
 (envelope-from iateaca@FreeBSD.org)
Date: Wed, 10 Aug 2016 17:25:11 GMT
Message-Id: <201608101725.u7AHPBaZ009223@socsvn.freebsd.org>
X-Authentication-Warning: socsvn.freebsd.org: www set sender to
 iateaca@FreeBSD.org using -f
From: iateaca@FreeBSD.org
To: svn-soc-all@FreeBSD.org
Subject: socsvn commit: r307412 - soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-soc-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the entire Summer of Code repository
 <svn-soc-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-soc-all/>
List-Post: <mailto:svn-soc-all@freebsd.org>
List-Help: <mailto:svn-soc-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2016 17:25:11 -0000

Author: iateaca
Date: Wed Aug 10 17:25:10 2016
New Revision: 307412
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=307412

Log:
  
  it is not necessary to check for error on notify codec
  
  M    pci_hda.c

Modified:
  soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c

Modified: soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c
==============================================================================
--- soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c	Wed Aug 10 16:31:15 2016	(r307411)
+++ soc2016/iateaca/bhyve-hda-head/usr.sbin/bhyve/pci_hda.c	Wed Aug 10 17:25:10 2016	(r307412)
@@ -653,7 +653,6 @@
 	uint32_t sdctl = 0;
 	uint8_t strm = 0;
 	uint8_t dir = 0;
-	int err;
 	int i;
 
 	assert(!st->run);
@@ -715,8 +714,7 @@
 
 	st->run = 1;
 
-	err = hda_notify_codecs(sc, 1, strm, dir);
-	assert(!err);
+	hda_notify_codecs(sc, 1, strm, dir);
 
 	return 0;
 }
@@ -727,14 +725,12 @@
 	struct hda_stream_desc *st = &sc->streams[stream_ind];
 	uint8_t strm = st->stream;
 	uint8_t dir = st->dir;
-	int err;
 
 	DPRINTF("stream: 0x%x, strm: 0x%x, dir: 0x%x\n", stream_ind, strm, dir);
 
 	st->run = 0;
 
-	err = hda_notify_codecs(sc, 0, strm, dir);
-	assert(!err);
+	hda_notify_codecs(sc, 0, strm, dir);
 
 	return 0;
 }